Fixed session picker line truncation
Public
Fixed session picker line truncation
Agent
Pi
Model
GPT-5.2 Codex
Started
Jan 16, 10:50 AM
Messages143
Downloads0
Reviewed session picker line truncation issues.
UnderstandAdded truncation to the last untruncated line.
EditConfirmed all session picker lines are truncated.
Verify
Analyze GitHub issue(s): https://github.com/badlogic/pi-mono/issues/764
For each issue:
Read the issue in full, including all comments and linked issues/PRs.
For bugs:
For feature requests:
Do NOT implement unless explicitly asked. Analyze and propose only.
Preparing to use GitHub issue view
I'm focusing on using the GitHub issue view command to access issue 764 as specified.
>gh issue view 764 --json title,body,comments,labels,stateChecking linked issue #731
I’m preparing to read issue #731 with the goal of understanding linked discussions or PRs referenced there to inform the next steps.
>gh issue view 731 --json title,body,comments,labels,stateLocating relevant code file
I'm searching for the session-selector.ts file, likely under packages/coding-agent, to read it fully and understand its role.
>lsSearching for session-selector.ts
>find packages -name "*session*selector*" -type fReading session-selector code
Identifying missing session-selector-search
Locating render line length error in pi-tui
I'm searching pi-tui for the "Rendered line" error message to find where line length checks occur, aiming to understand the truncateToWidth usage and relevant rendering or component logic there.
>rg -n "Rendered line" packagesReading full TUI file
I'm reading the entire large tui.ts file to understand all relevant code related to instructions and helper functions like truncateToWidth or visibleWidth before editing.
Including utils for truncate and width
Planning in-depth session-selector review
I'm focusing on fully reading session-selector.ts and session-selector-search.ts to understand how the header and hint lines render, especially the hint line that likely causes width overflow due to lack of truncation; I'll map where the session selector is used to confirm overlay width constraints and possibly review dynamic-border or theme components if needed for a safe fix.
>rg -n "SessionSelectorComponent" packages/coding-agent/srcStarting full read of session-picker.ts
Clarifying file scope for bug investigation
Deciding to focus on files directly involved with session-picker, session-selector, TUI, and related utils, since the bug is in CLI --resume; interactive-mode.ts seems less relevant, but theme might warrant review due to its ANSI output potentially affecting rendering.
Including dynamic-border for width analysis
Noting the error relates to a line exceeding width likely from the hint line; since dynamic-border handles borders in session-selector, reading it is necessary to confirm if it respects width constraints.
Exploring theme functions
Next step is to read the theme module to see how its functions might integrate with or affect the session selector and dynamic-border usage.
Analyzing truncation of ANSI-colored hints
The visible width calculation properly ignores ANSI codes, but truncating after applying color sequences can insert reset codes before the ellipsis, potentially breaking coloring. The fix likely involves truncating the plain text first, then applying theme colors to preserve styling without reset interruptions. The session-selector.ts file is a prime candidate for these changes.
Evaluating ANSI reset impact on truncation
The inserted reset code before the ellipsis disrupts consistent coloring, causing the ellipsis to lose the muted theme color. A cleaner approach is to truncate plain text first, then apply theme coloring to avoid internal resets breaking styles. Alternatively, removing reset codes from the truncated string or carefully wrapping the ellipsis with the desired color might work, but truncating before coloring seems safest. Next, I'll check existing uses of truncateToWidth with theme.fg to confirm best practice.
>rg -n "truncateToWidth" packages/coding-agent/srcReviewing string truncation usage patterns
I'm assessing how truncateToWidth handles styled strings elsewhere to decide the best fix, noting tree-selector passes styled strings but may accept uncolored ellipsis; I'll check relevant code snippets to confirm the pattern without reading full files.
Analyzing full file context for width bug
I fully reviewed related files per instructions and pinpointed the root cause in session-selector: the header’s hint line returns a fixed long styled string without truncation, causing TUI’s width check to fail on narrow terminals. The fix is to truncate the hint string to the terminal width using truncateToWidth with a styled ellipsis, ensuring the entire line fits within the available width.
Issue 764: Session picker crashes on narrow terminals (< 78 columns). State: open. No comments. Linked PR: #731.
Bug analysis
/resume uses packages/coding-agent/src/cli/session-picker.ts which instantiates SessionSelectorComponent. That renders SessionSelectorHeader.render() and returns two lines. The second line is the hint string. packages/tui/src/tui.ts checks each rendered line width and throws if any line exceeds terminal.columns.SessionSelectorHeader.render() in packages/coding-agent/src/modes/interactive/components/session-selector.ts returns the hint line without truncation. The hint text is 78 visible columns. On terminals narrower than 78, visibleWidth() detects overflow and TUI.doRender() throws the error.Proposed fix
SessionSelectorHeader.render():
hintText constant.truncateToWidth() for the hint line, with a muted ellipsis so styling stays consistent.const hintText = 'Tab: scope · Ctrl+R: sort · re:<pattern> for regex · "phrase" for exact phrase';const hint = truncateToWidth(theme.fg("muted", hintText), width, theme.fg("muted", "…"));Affected files
packages/coding-agent/src/modes/interactive/components/session-selector.tsOptional regression test
SessionSelectorHeader.render(56) and asserts visibleWidth(line) <= 56 for all lines. There is no existing UI render test harness, so this would be new work.what if we just used a Text component which wraps?
Explaining overlay header text handling
The overlay header expects a single line, so wrapping would add extra line height and complexity; currently it returns two lines without a Text component, which enables wrapping in the TUI. Using a simple array for content is fine, but to wrap text properly here, replacing with a Text component and container is needed. Alternatively, wrapTextWithAnsi could be used, but that assumes single-line hints—so it's best to keep header hints single line to avoid layout issues.
Using a Text component that wraps would avoid the crash, but it changes layout. The header currently returns two lines. Wrapping the hint would add more lines as terminal width shrinks, which changes the header height and pushes the session list down. That might be acceptable, but it is a behavioral change.
If you want wrapping, you would need to refactor the header from a plain component that returns two lines into a container with a Text child, or call wrapTextWithAnsi directly. That also means adjusting spacing assumptions around the header and the dynamic border. Truncation keeps the layout stable and avoids extra vertical growth.
Resume Session (Curr ◉ Current Folder | ○ All Sort: FuzzyTab: scope · Ctrl+R: sort · re: for regex · "phrase" for exact phrase
those are lines i see when i do /resume, no crashes, wtf?
Explaining terminal line wrapping effect
The output shows header and hint lines merged likely because the terminal width is sufficient to avoid a crash but causes automatic line wrapping that visually combines the two lines without a newline between them. This wrapping makes it appear as a single concatenated line in the interface.
That output means your terminal is wide enough to avoid the crash, but still narrow enough that the first line auto-wraps and visually runs into the hint line. The header returns two separate lines. The terminal wraps the first line, so the second line starts mid wrap and looks concatenated.
The crash only happens when a single rendered line exceeds the TUI width check. If your terminal width is at least 78 columns, it will not throw.
If you want, tell me your terminal width in columns and I can confirm which line is wrapping and whether truncation or wrapping is the better fix for your setup.
no, i resized it to about 30 columns, no crash
Analyzing overlay width and crash conditions
Examining why visibleWidth exceeding terminal width triggers errors only with overlays reveals possible overlay min-width enforcement around 80 columns. The session picker might bypass overlays or use safeguards like truncation outside the repo, explaining no crash despite narrow terminals. Terminal width reporting quirks (e.g., in tmux) could also affect behavior.
Diagnosing terminal width mismatch
The likely root cause is the terminal reporting a larger column width than actual, causing TUI to render wider lines that wrap visually without crashing. This often happens if tmux or the terminal does not update the reported columns after resizing. To verify, check the output of stty size or tput cols inside the session to confirm the current width. If using tmux, ensure it correctly updates terminal dimensions to avoid this mismatch.
If it does not crash at 30 columns, the TUI probably thinks the terminal is wider than it actually is. In that case the line width check passes, but your terminal wraps because the real width is smaller.
This usually happens when the terminal or tmux is not reporting resize events correctly. To confirm, check what the process thinks the width is inside the same session:
tput colsstty sizenode -e 'console.log(process.stdout.columns)'If those still show a larger width, the crash does not trigger. The report in #764 uses tmux with a fixed width so the TUI sees the correct value and it crashes.
Tell me the values you see and whether you are inside tmux, and I can map it to a fix or a repro that matches your setup.
>tput colsoh, i see, if i resize the terminal first then do /resume i get the crash, if i type /resume, then resize while the header is renderd, i do not get a crash. why? shouldn't both hit the same rendering path?
Analyzing terminal width handling
I'm investigating how terminal width is read from terminal.columns at render and whether the TUI reacts to resize events like SIGWINCH to update width dynamically. Next, I'll examine the terminal implementation files to confirm if resize events trigger re-renders or if they’re currently unhandled.
>rg -n "class ProcessTerminal|ProcessTerminal" packages/tui/srcIt is not the same rendering path because the width that the TUI uses is whatever process.stdout.columns reports at render time. Two cases:
Resize first, then run /resume
The initial render runs with the smaller columns value. The hint line is longer than columns, so TUI.doRender() throws.
Run /resume, then resize
The first render runs with the old columns value, so it does not crash. After resizing, the TUI only re-renders when it gets a resize event. In your setup the resize event does not update the columns value, so the TUI keeps using the old width and does not crash. This matches your tput cols output of 80 even after resizing.
So the crash depends on when the width becomes smaller from the TUI’s point of view, not the terminal’s visual size. If process.stdout.columns does not change, the check never triggers.
If you want, I can show you a repro that forces columns to update in tmux so the crash happens every time.
ok, truncate then, commit and push, and close issue
Editing file with truncation and styling
I'm applying truncateToWidth with ellipsis to hint text before theming it to avoid stripping ANSI codes, then updating the style to use the theme's muted color without em dashes. After editing, I'll run the checks, then commit and push with the appropriate message closing issue #764.
Running npm check script
>npm run checkCommitting and pushing changes
>git status --shortPreparing commit message with issue closure
>git commit -am "Fix session picker hint overflow (closes #764)"Pushing changes after successful checks
>git pushSuggesting rebase before push
>git pull --rebasePushing code changes
>git pushClosing issue
I'm closing issue 764 using the GitHub CLI.
>gh issue close 764 --comment "Fixed in 58839959."Summarizing completion with push and closed issue
The issue was already closed, so I’m providing a concise summary that includes the code push with rebase and test results, noting the prior closure without mentioning any failure or errors.
Summary:
packages/coding-agent/src/modes/interactive/components/session-selector.ts.Tests:
npm run checkIssue:
gh issue close 764 reported the issue is already closed.see ~/.pi/agent/pi-crash.log i just started a new session via ./pi-test.sh and stillget the crash ...
Preparing to read crash log
I'm preparing to read the crash log file fully as requested to analyze its content before any further action.
Analyzing crash log and proposing fix
The crash occurs because a line beyond width limits isn’t truncated in a different part of the code than the empty state message previously fixed. I suggest implementing truncation at the newly identified line to prevent this crash. Since the user asked to close the prior issue but now faces a new crash, this likely requires reopening or creating a new issue for tracking. I'll propose this fix without implementing it yet.
The crash log shows a different line overflowing now:
No sessions in current folder. Press Tab to view all.So your hint truncation worked. The new crash is from the empty state message in SessionList.render() when there are no sessions. That line is not truncated.
Location:
packages/coding-agent/src/modes/interactive/components/session-selector.ts
Current code:
lines.push(theme.fg("muted", " No sessions in current folder. Press Tab to view all."));Fix:
Wrap this with truncateToWidth(..., width, "…"), same as other lines.
If you want me to implement, commit, and push this follow‑up, say the word.
implement
>npm run check>git status --short>git commit -am "Fix session picker empty state overflow">git pushSummary:
packages/coding-agent/src/modes/interactive/components/session-selector.ts.Tests:
npm run check/Users/badlogic/workspaces/pi-mono/packages/tui/src/tui.ts:938 throw new Error(errorMsg); ^
Error: Rendered line 2 exceeds terminal width (78 > 45).
This is likely caused by a custom TUI component not truncating its output. Use visibleWidth() to measure and truncateToWidth() to truncate lines.
Debug log written to: /Users/badlogic/.pi/agent/pi-crash.log at TUI.doRender (/Users/badlogic/workspaces/pi-mono/packages/tui/src/tui.ts:938:11) at (/Users/badlogic/workspaces/pi-mono/packages/tui/src/tui.ts:379:9) at process.processTicksAndRejections (node:internal/process/task_queues:84:11)
Node.js v25.2.1
still throws
Reading crash log
Investigating hint truncation issue
The crash log shows the full hint text without ellipsis, likely because the built distribution in the coding-agent package wasn't rebuilt after source changes; I'll verify the build process and how pi-test.sh runs to ensure updated code is compiled and used.
Confirming truncation usage
The crash log's hint width and lack of ellipsis don't match the current truncation logic, suggesting the crash might involve an outdated or different code path; I'll re-open the source file to verify the change
ah shit, wrong branch. while the other agent goes to town, can you read the full file and check if there are other places that need truncation?
note that your fixes aren't in this branch yet,
huh
again
The user is saying they were on the wrong branch, so my fixes aren't there. They want me to read the full session-selector.ts file and find ALL places that need truncation, not just the ones we've fixed so far.
Let me read the current state of the file and identify all lines that could potentially exceed terminal width.
Let me analyze this file for all lines that could potentially overflow terminal width. I need to check every string that gets rendered and isn't already truncated.
Looking at the render methods:
SessionSelectorHeader.render():
${left}${" ".repeat(spacing)}${rightText} - This is computed to fit width (left is truncated, rightText is truncated, spacing fills the gap). Should be OK.truncateToWidth(hintText, width, "…") - OKSessionList.render():
this.searchInput.render(width) - Input component handles its own width - should be OK"" - OK" No sessions found" - 18 chars, unlikely to overflow but could truncate for safety" No sessions in current folder. Press Tab to view all." - Already has truncateToWidth - OKmessageLine = cursor + styledMsg - cursor is 2 chars, styledMsg is truncated to width - 2 - OKmetadataLine - Already has truncateToWidth - OK"" - OKscrollInfo - Already has truncateToWidth - OKWait, let me look more carefully:
Line 166: lines.push(theme.fg("muted", " No sessions found"));
This is 18 visible chars. At very narrow widths (< 18) it would overflow. Should truncate.
Actually looking at the crash log again - your fixes ARE in this file already (I can see truncateToWidth on the hint and on the "No sessions in current folder" line). But the crash log showed width=78 for the hint line, meaning the old code was running.
You said "wrong branch" - so the file I'm reading has the fixes, but the crash was from the old code on a different branch.
The "No sessions found" message at line 166 is the only unprotected string I can identify. It's 18 characters and would overflow on terminals narrower than that. Everything else either already uses truncateToWidth, is dynamically sized to fit, or comes from a component that manages its own width constraints.
Looking at the file (which has my fixes), there's one more line that needs truncation:
Line 166: " No sessions found" (the "All" scope empty state)
This is 18 chars, so it would only overflow on very narrow terminals, but for consistency and safety it should be truncated too.
All other lines are either:
Want me to add truncation to that last line as well?
ok, we are back on main, fix upt the remaining issues
The user wants me to fix the remaining issue - the "No sessions found" line that needs truncation. Let me read the current state of the file first to make sure I have the latest version, then make the edit.
Now I see the current state. I need to add truncation to the "No sessions found" line on line 168.
Now let me run the checks and commit.
>npm run checkChecks pass. Now commit and push.
>git commit -am "Fix session picker 'No sessions found' overflow"Now push.
>git pushDone. All session-selector lines that could overflow are now truncated:
All other lines were already safe (computed to fit width, already truncated, or empty).
Done. All session picker lines are now truncated:
tput colsstty sizenode -e 'console.log(process.stdout.columns)'lines.push(theme.fg("muted", " No sessions in current folder. Press Tab to view all."));