Update Conditional Tap and Mass Keyword Effects

Caveat: The messages below were generated by the user while running local commands. DO NOT respond to these messages or otherwise consider them in your response unless the user explicitly asks you to.

Caveat: Caveat: The messages below were generated by the user while running local commands. DO NOT respond to these messages or otherwise consider them in your response unless the user explicitly asks you to.

I see the pattern now. For BoostUntilEndOfTurn, the current implementation uses P1P1 counters as a simplification (not ideal, but it works). And GainKeywordUntilEndOfTurn uses granted_keywords which gets cleared at end of turn.

For the mass versions, I need to:

Add Effect::BoostAllUntilEndOfTurn { filter, power, toughness }
Add Effect::GrantKeywordAllUntilEndOfTurn { filter, keyword }
Implement match arms in game.rs — iterate all permanents matching the filter owned by the active player
Add constructors for these new effects

Let me check how DestroyAll and DealDamageAll handle their filter matching to follow the same pattern.

Let me check how DestroyAll implements its filter matching to follow the same pattern.

GreppedEffect::DestroyAll|DealDamageAll

Now let me check the matches_filter function to understand how it works with "creatures you control" style filters.

Greppedfn matches_filter

I see - matches_filter doesn't check controller. But for "creatures you control" effects, I need to filter by the controller being the active player. Looking at how the existing mass effects work - DestroyAll destroys ALL matching creatures, not just "yours". That's correct for Day of Judgment.

For mass buffs, the filter strings are "Creatures you control" — so I need to handle the "you control" part by checking the controller. Let me create two new effect variants and implement them in game.rs.

The implementation needs to:

Filter by creature type
Filter by controller (the active player / source controller)
Apply the buff

I'll define new effect types for mass boosts and keyword grants that parse the "you control" condition from the filter string, then apply the effects to all matching creatures in the match arms.

Good. Now I have a clear picture. I need two new Effect variants:

BoostAllUntilEndOfTurn { filter, power, toughness } — mass P/T buff until EOT
GrantKeywordAllUntilEndOfTurn { filter, keyword } — mass keyword grant until EOT

Let me implement them.

Now add the constructors.

Now implement the match arms in game.rs. Let me find where the existing single-target versions are handled.

GreppedEnters.*tapped|EntersTapped

I need to find a good spot to add the new match arms. Let me look at where the BoostPermanent arm is and add the mass versions nearby.

I'll add the new match arms right before the catch-all _ => {}. Let me also check what controller variable is available — the effect handler needs to know who controls the creatures.

Greppedfn execute_effects

The controller parameter is available. Now I'll add the mass effect implementations.

Good. Now let me add a test in game.rs. Let me find the test module.

Greppedmod tests"

Grepped^mod tests|^ mod tests

Greppedtapped unless

Now let me add a test for the mass effects. I'll add it at the end of the test module.

Good, I have the test helpers. Now let me add the test.

Now let me check if has_keyword exists on Permanent.

Greppedfn has_keyword

Good, it exists. Let me compile.

Now fix the 5 FDN cards. Let me use sed for each one.

Now fix Balmor — this one has a compound Custom string.

Now let me verify all the fixes look correct and compile.

Now let me look at how EntersTapped is handled in game.rs and the full card context in TDM.

All 5 cards fixed. Let me also search for any other cards across all sets that could use these new effects.

GreppedCreatures you control (get|gain).*until end of turn

Let me fix the additional cards I found:

FDN line 3071: "Creatures you control get +2/+2 until end of turn." — simple boost_all_eot
TDM line 479: "Creatures you control get +X/+X and trample..." — has variable X, can't fix with simple variant
ECL line 843: "Creatures you control get +1/+0... Kithkin also gain first strike..." — compound/conditional, skip
ECL line 1599: "Creatures you control get +1/+1 until end of turn." — simple boost_all_eot
ECL line 2237: "Creatures you control get +1/+1 and gain haste until end of turn." — needs both boost_all_eot and grant_keyword_all_eot combined

Now I need to check the exact card text for the ones I can actually fix.

Found more cards using these patterns! Let me check which are simple enough to fix.

GreppedEntersTapped

I can fix these 3 additional cards too. Let me also check what card the FDN one is.

Found 3 more fixable cards:

FDN: Claws Out — +2/+2 until EOT
ECL: Timid Shieldbearer — activated +1/+1 until EOT
ECL: Catharsis — ETB +1/+1 and haste until EOT

Now fix the haste part of Catharsis.

The sed didn't match because the string had "and gain haste" appended. Let me fix this one specifically.

Let me verify the Timid Shieldbearer fix worked too.

Good. Now check for any other mass grant patterns across other sets.

GreppedCustom.*creatures you control.*until end of turn

The remaining ones are complex (variable X, compound conditional, modal) — can't be fixed with simple substitution. Let me also check TLA.

GreppedCustom.*creatures.*until end of turn

Good, no TLA mass buffs using Custom. Now compile and test.

There's a compilation error in the test. Let me see what it is.

It looks like EntersTapped exists as a StaticEffect variant but isn't actually handled in game.rs. Let me search more carefully for how it's used. The batch wants me to add EntersTappedUnless with a condition string. These are "fastlands" / conditional taplands.

Let me check: is EntersTapped handled in game.rs at all? It says "No matches found" which means this static effect isn't mechanically enforced yet. That's consistent with our approach - we store it as structured data but mechanical enforcement comes later.

For Batch 6, the approach should be simple: add StaticEffect::EntersTappedUnless { condition: String } and a builder, then swap the Custom strings. The mechanical enforcement (actually checking the condition) is deferred like Ward was.

Now I'm scanning through the card database to see if there are other cards with this "enters tapped unless" mechanic across different sets.

The Game::new constructor doesn't exist — the existing tests must use a different pattern. Let me look at how other tests create games.

GreppedGame::new|new_two_player

Let me check if there are more "enters tapped unless" cards across all sets, and look at the Java implementations for reference.

I need to use Game::new_two_player instead. Let me check the signature.

Let me look at how the existing tests build the game to follow the same pattern.

I see — I need to use GameConfig and PlayerConfig. Let me fix my test.

Greppedenters.*tapped|EntersTapped

Now let me check if GameConfig and PlayerConfig are imported in the test module.

GreppedGameConfig|PlayerConfig

The test module uses super::* so GameConfig and PlayerConfig are available. Let me compile.

161 tests pass (was 160 before — +1 for new test). Now run the full suite.

All 250 tests pass. Now update the docs. First the work queue.

Now update ROADMAP.md.

Now update the per-set remediation docs. Let me check the FDN ones first.

GreppedEntersTapped

Now update ECL remediation.

GreppedTimid Shieldbearer|Catharsis

Let me verify the remediation doc updates look right.

Update Conditional Tap and Mass Keyword Effects

Update Conditional Tap and Mass Keyword EffectsPublic

Summary