Update Engine for Self-Targeting Counter Effects

Summary

Caveat: The messages below were generated by the user while running local commands. DO NOT respond to these messages or otherwise consider them in your response unless the user explicitly asks you to.

Caveat: Caveat: The messages below were generated by the user while running local commands. DO NOT respond to these messages or otherwise consider them in your response unless the user explicitly asks you to.

Readabilities.rs

Greppedtrigger|Trigger

So triggered abilities are NOT YET implemented for the stack. The game has a TODO for "Put triggered abilities on the stack (task #13)". This means that the ETB counters on Heirloom Auntie don't actually work yet either, and the AddCounters with TargetSpec::None is just a representation that will work later.

Given this state, I should still make the card data correct. The fix for batch 2d is simple then: just swap Custom(...) for the correct typed effects, even if they won't fully work until triggered abilities are implemented. The card representations should be correct.

But wait, the work queue says to add "add counters to self" logic. Since triggered abilities don't work yet at all, let me decide:

I'll fix the card data by replacing the custom effects with proper typed effects, and add source plumbing to the effect execution so that when triggers eventually work, the counter logic will already be in place.

For the ETB self-counter effects, I'm considering whether they should be handled at permanent creation time like EntersTapped, but that's a bigger design change—I'll keep it simple for now and just do the straightforward swaps.

Now I'm mapping out the batch 2 work: DestroyAll for Day of Judgment is a simple swap since it already exists, and EntersTapped for Diregraf Ghoul needs to replace the custom static effect with the proper typed version.

I need to check what filter parameter EntersTapped expects and whether there are existing uses I can reference...

Let me check existing EntersTapped usage in cards and how it's handled by the engine.

GreppedEntersTapped

Good — EntersTapped { filter: "self".into() } is the established pattern. Now let me look at the Sting-Slinger cost issue and understand how Blight cost works in game.rs.

GreppedBlight

Greppedpay_costs|check_costs|fn pay

Readgame.rs80 lines

OK, now I have a clear picture. Let me plan my approach for batch 2:

2a: DestroyAll — Day of Judgment

Simple swap: Effect::Custom("Destroy all creatures.".into()) → Effect::destroy_all("creatures")

2b: EntersTapped — Diregraf Ghoul

Simple swap: StaticEffect::Custom("Enters tapped.".into()) → StaticEffect::EntersTapped { filter: "self".into() }

2c: CantBlock (target) — Frenzied Goblin, Brambleback Brute (ECL, not "Skoa Veteran")

Simple swap: Effect::Custom("Target creature can't block this turn.".into()) → Effect::CantBlock

2d: Self -1/-1 counters — ECL blight creatures This is the tricky one. The engine needs a modification so that execute_effects receives source information, allowing AddCounters and RemoveCounters to default to the source permanent when no explicit targets are specified. I need to update the function signature to include source context and then thread that through the resolution logic.

For Sting-Slinger, I'm realizing the -1/-1 counter is actually part of the activation cost rather than an effect. Since the Blight mechanic already exists in the Cost enum, I could add Cost::Blight(1) directly to the costs array, or I could use the general self-counter approach depending on how the ability text is structured.

Looking at the actual card text, everything before the colon represents the cost, so I should model it as costs including the mana payment, tap, and the -1/-1 counter, with the damage effect separate. The issue is that Cost::Blight isn't currently handled in the pay_costs function, so I need to implement that handler first.

Actually, let me step back and focus on what's realistic to accomplish. The real goal here is replacing those Custom effect stubs with proper typed effects. I should add source_id plumbing to the effect execution, make the counter operations use source when there's no explicit target, and then fix the card data itself. For Sting-Slinger specifically, I'll move the counter to a Cost::Blight and implement the handler.

Looking at the specific cards in batch 2d, I need to swap out the Custom stubs for AddCounters and RemoveCounters across Blighted Blackthorn, Sourbread Auntie, Sting-Slinger, and Heirloom Auntie. The main engine consideration is whether AddCounters can handle self-targeting when no target is selected, or if I need to pass the source object ID explicitly—might need a small tweak to default to source when targets are empty. handle the case where targets is empty (fall back to source).

Let me plan:

Engine change: Modify execute_effects to accept source: Option<ObjectId>. When AddCounters/RemoveCounters has empty targets and source is Some, apply to source.
Card fixes: I need to swap several cards to use typed effects instead of custom strings. Day of Judgment becomes destroy_all("creatures"), Diregraf Ghoul gets EntersTapped with a self filter, Frenzied Goblin and Brambleback Brute use CantBlock, and I'm replacing a bunch of counter-related custom effects with proper RemoveCounters calls. There are also a few draw and discard effects to standardize, plus some extra cards in the ECL file that need the same counter treatment.
Validation: After making these changes, I'll run the tests to make sure nothing breaks.
Documentation: I should document what changes were made and why, so future maintainers understand the refactoring.
Code Review: Before submitting, I'll review the changes one more time to catch any edge cases or inconsistencies.

Let me start by identifying all the cards that need updating and grouping them by the type of change needed. This will help me tackle them systematically and avoid missing any.

Looking at the cards with -1/-1 counter effects, I can see several patterns:

Simple "remove a -1/-1 counter" effects that map to Effect::remove_counters
Compound effects like Warren Torchmaster that need to be split
Cost-based effects that aren't ready to refactor yet
Complex effects like DestroyAll with counters that need new variants

For the ones I can fix now, I'll focus on the straightforward removals and the compound effects that can be cleanly separated. The trickier ones like the spell that puts counters on all creatures will need more thought, so I'll defer those. Now I'm identifying which cards need updates across both sets — Day of Judgment and several creatures from FDN, plus a longer list from ECL including Brambleback Brute and others. I should also verify what's at those specific line numbers and check if there are other EntersTapped patterns I'm missing in the codebase.

Let me check the remaining cards I found and check for more matches.

Readecl.rs20 lines

Readgame.rs

Readecl.rs20 lines

Readfdn.rs20 lines

Good. Now I have a complete picture. Let me also check the "Skoa Veteran" card that was mentioned in batch 2c but not found. It may have a different name in the code.

Let me also check what ECL card was at the line reference for can't block.

The search earlier found Brambleback Brute at ECL line 429-432 with the can't block Custom effect. The work queue mentions "Skoa Veteran" but the actual card is "Brambleback Brute."

Now let me also check for more "Enters tapped" Custom patterns in TLA and TDM:

Let me check for any other StaticEffect::Custom("Enters tapped") patterns across all sets.

GreppedCustom\("Enters tapped

Only the Diregraf Ghoul has the simple "Enters tapped" Custom — the TDM ones are conditional (batch 6). Good.

Now I have the full picture. Let me also check what the RemoveCounters match arm looks like more carefully and read the rest of execute_effects.

Readgame.rs120 lines

Now I have all the information I need. Let me now implement batch 2.

Let me plan the implementation:

Engine changes (game.rs):

Add source: Option<ObjectId> parameter to execute_effects
In AddCounters: when targets is empty and source is Some, apply counters to source
In RemoveCounters: same fallback
Update callers:
- Line 741 (spell): pass Some(item.id)
- Line 750 (ability): capture source_id and pass Some(*source_id)
- Test callers: pass None

Card changes:

2a: FDN Day of Judgment - Replace the custom effect string with a dedicated destroy all creatures effect.

2b: FDN Diregraf Ghoul - Replace the custom static effect with an enters tapped effect that targets self.

2c: FDN Frenzied Goblin + ECL Brambleback Brute - Need to handle similar effect conversions.

2d: ECL self -1/-1 counters - Converting multiple cards that add -1/-1 counters to use a dedicated counter effect instead of custom strings. Blighted Blackthorn, Sourbread Auntie, and Sting-Slinger all need this same refactor.

For Sting-Slinger specifically, I considered moving the counter to a cost using Cost::Blight, but that doesn't work since Blight is meant for choosing any creature you control, whereas this effect targets only the card itself. I'll keep it as an effect for now.

Also need to handle Heirloom Auntie's counter removal with a proper RemoveCounters effect.

Looking at similar patterns across other cards—Encumbered Reejerey, Reluctant Dounguard, and an unnamed creature with Ward—they all follow the same counter removal structure.

Then there are a few more straightforward conversions: Icewind Elemental needs to split its enter effect into separate draw and discard actions, and Mistmeadow Council just needs a simple draw effect.

Now I'm finding additional cases like FDN Ref that need attention, including a counter spell that requires both the effect conversion and a target specification fix, plus Warren Torchmaster which has a tricky split between self-targeting counters and creature-targeting haste.

The core issue with Warren Torchmaster is that both effects would share the same target list, so if there's a creature target for the haste, the counter logic would incorrectly apply to that creature instead of the card itself. I'll need to leave this one as a custom effect for now and come back to it once I have a better pattern for handling mixed self and external targets.

Dream Seizer has a similar problem—it needs a counter on itself but also triggers a batch effect (opponent discard), which doesn't fit the current framework. And the creature at line 1843 would require a new variant to handle counters on all creatures at once. I'll skip both of those for now and check what else needs handling.

Good. I now have a complete picture. Let me implement everything. I'll start with the engine change to execute_effects, then fix all the cards.

Let me first modify the engine to support "add/remove counters on self" when no targets are provided.

Readgame.rs15 lines

Now I'll make the changes. The approach:

Add source: Option<ObjectId> to execute_effects
For AddCounters/RemoveCounters: fall back to source when targets is empty
Pass source from resolve callers
Fix all cards

Now update the execute_effects signature and add the source fallback for AddCounters/RemoveCounters.

Now update the AddCounters match arm to fall back to source:

Now update RemoveCounters the same way:

Now let me investigate each sub-batch by finding the exact card lines. Let me search in parallel.

Now update the test callers of execute_effects:

Readgame.rs30 lines

GreppedCustom\("Destroy all creatures\."\)

Good. Now let me add a test for the self-counter behavior, then fix all the cards. Let me first check compilation and tests.

Engine compiles. Now let me add a test for self-counters, then fix all the cards. Let me find the test section in game.rs.

Readgame.rs40 lines

Readgame.rs30 lines

Now let me add a test for self-counters at the end of the test module.

All 159 engine tests pass. Now let me fix all the cards. I'll do them in parallel using sed for efficiency.

>\
# 2a: Day of Judgment
sed -i 's/vec!\[Effect::Custom("Destroy all creatures.".into())\]/vec![Effect::destroy_all("creatures")]/' mtg-cards/src/sets/fdn.rs && \
# 2b: Diregraf Ghoul
sed -i 's/vec!\[StaticEffect::Custom("Enters tapped.".into())\]/vec![StaticEffect::EntersTapped { filter: "self".into() }]/' mtg-cards/src/sets/fdn.rs && \
# 2c: Frenzied Goblin
sed -i 's/vec!\[Effect::Custom("Target creature can'\''t block this turn.".into())\]/vec![Effect::CantBlock]/' mtg-cards/src/sets/fdn.rs && \
echo "FDN 2a/2b/2c done"

Now the 2d self-counter fixes for ECL:

GreppedCustom\("Enters tapped\."\)

>\
# 2d: Blighted Blackthorn (2 lines)
sed -i 's/vec!\[Effect::Custom("Put two -1\/-1 counters on Blighted Blackthorn.".into()), Effect::draw_cards(1), Effect::lose_life(1)\]/vec![Effect::add_counters("-1\/-1", 2), Effect::draw_cards(1), Effect::lose_life(1)]/g' mtg-cards/src/sets/ecl.rs && \
# 2d: Sourbread Auntie
sed -i 's/vec!\[Effect::Custom("Put two -1\/-1 counters on Sourbread Auntie.".into()), Effect::create_token("1\/1 Goblin", 2)\]/vec![Effect::add_counters("-1\/-1", 2), Effect::create_token("1\/1 Goblin", 2)]/' mtg-cards/src/sets/ecl.rs && \
# 2d: Sting-Slinger
sed -i 's/vec!\[Effect::Custom("Put a -1\/-1 counter on Sting-Slinger.".into()), Effect::damage_opponents(2)\]/vec![Effect::add_counters("-1\/-1", 1), Effect::damage_opponents(2)]/' mtg-cards/src/sets/ecl.rs && \
# 2d: Heirloom Auntie (remove counter)
sed -i 's/vec!\[Effect::scry(1), Effect::Custom("Remove a -1\/-1 counter from Heirloom Auntie.".into())\]/vec![Effect::scry(1), Effect::RemoveCounters { counter_type: "-1\/-1".into(), count: 1 }]/' mtg-cards/src/sets/ecl.rs && \
echo "ECL 2d main cards done"

Now the additional RemoveCounters cards found:

>\
# Encumbered Reejerey
sed -i 's/vec!\[Effect::Custom("Remove a -1\/-1 counter from Encumbered Reejerey.".into())\]/vec![Effect::RemoveCounters { counter_type: "-1\/-1".into(), count: 1 }]/' mtg-cards/src/sets/ecl.rs && \
# Reluctant Dounguard
sed -i 's/vec!\[Effect::Custom("Remove a -1\/-1 counter from Reluctant Dounguard.".into())\]/vec![Effect::RemoveCounters { counter_type: "-1\/-1".into(), count: 1 }]/' mtg-cards/src/sets/ecl.rs && \
# Unknown creature with Ward {2} (line ~2197)
sed -i 's/vec!\[Effect::Custom("Remove a -1\/-1 counter from this creature.".into())\]/vec![Effect::RemoveCounters { counter_type: "-1\/-1".into(), count: 1 }]/' mtg-cards/src/sets/ecl.rs && \
echo "ECL extra remove-counter cards done"

Now batch 2e (loot — Icewind Elemental in FDN) and 2f (ETB draw — Mistmeadow Council in ECL):

>\
# 2e: Icewind Elemental (loot = draw then discard)
sed -i 's/vec!\[Effect::Custom("When this creature enters, draw a card, then discard a card.".into())\]/vec![Effect::draw_cards(1), Effect::discard_cards(1)]/' mtg-cards/src/sets/fdn.rs && \
# 2f: Mistmeadow Council (ETB draw)
sed -i 's/vec!\[Effect::Custom("When this creature enters, draw a card.".into())\]/vec![Effect::draw_cards(1)]/' mtg-cards/src/sets/ecl.rs && \
echo "2e and 2f done"

Now let me also fix the bonus card I found — Refute (FDN) which has counter spell + loot:

Also need to fix Refute's target — it says "Counter target spell" but has TargetSpec::None:

Readfdn.rs12 lines

Now let me verify all changes compiled correctly:

Now run all tests:

GreppedCustom\("Target creature can't block this turn\."\)

There are callers in mtg-tests that also need updating. Let me find and fix them.

Greppedexecute_effects\(

Readframework.rs80 lines

The sed replaced ) → , None) but it left the formatting as , None); which would compile but looks ugly. Actually wait, it turned ); into , None); but the ) and ; were on different lines - the ) was closing the function call and was on the same line as a parameter. Let me look more carefully: game.execute_effects( &[Effect::Destroy], test.player_a_id, &[bear_id], , None);

Wait, this isn't right. The original was:``` game.execute_effects( &[Effect::Destroy], test.player_a_id, &[bear_id], );


The sed turned `);` into `, None);` which gives:```        game.execute_effects(            &[Effect::Destroy],            test.player_a_id,            &[bear_id],        , None);


The sed turned `);` into `, None);` which gives:```        game.execute_effects(            &[Effect::Destroy],            test.player_a_id,            &[bear_id],        , None);

This is syntactically valid Rust (trailing comma before , None)) — wait, actually the trailing comma after &[bear_id], followed by , None) would give &[bear_id], , None) which has a double comma, so this won't compile.

Looking more carefully at what sed did: the ) and ; on the line ); became , None);. So the function call ends up as:

There's no double comma issue here — the trailing comma after &[bear_id], is followed directly by , None); on the next line, which is valid syntax.

Wait, actually that's wrong. Looking at it again: &[bear_id], has a trailing comma, then the next line starts with , None);, which creates a double comma situation. That won't compile. I need to fix this properly by removing the trailing comma or adjusting how the sed replacement works.

The sed left bad formatting. Let me fix these properly.

Readframework.rs6 lines

GreppedCustom\("Put.*-1/-1 counter

All 246 tests pass (up from 245 — the new self-counter test). Now let me verify each card change is correct by spot-checking.

All fixes verified. Also let me check there's no remaining Custom("draw a card") in ECL:

That one is a conditional cost-based effect (pay 1 life to draw) — too complex for batch 2. Good.

Now let me update the docs. Let me first check what card is at ECL line 2187 (the creature with Ward {2} and remove counters):

Readecl.rs5 lines

Bristlebane Battler. Now let me update all the documentation files. Let me read the remediation docs to understand the format.

Ran sub-agentUpdate remediation docs

All docs updated. Let me verify everything is clean with a final check.

GreppedCustom\("Remove a -1/-1 counter

All 246 tests pass, zero errors. Let me do a quick summary of remaining Custom stubs eliminated:

>echo "=== Remaining Custom effects in FDN ===" && grep -c 'Effect::Custom' mtg-cards/src/sets/fdn.rs && echo "=== Remaining Custom effects in ECL ===" && grep -c 'Effect::Custom' mtg-cards/src/sets/ecl.rs && echo "=== Remaining Custom static effects in FDN ===" && grep -c 'StaticEffect::Custom' mtg-cards/src/sets/fdn.rs && echo "=== Remaining Custom static effects in ECL ===" && grep -c 'StaticEffect::Custom' mtg-cards/src/sets/ecl.rs

Batch 2 is complete. Here's the summary:

Batch 2: Easy swaps — DONE

Engine change

Added source: Option<ObjectId> parameter to execute_effects() in game.rs
AddCounters and RemoveCounters now fall back to the source permanent when no targets are provided (self-targeting counter effects)
Added test add_counters_self_when_no_targets

Cards fixed (15 effects across 14 cards)

FDN (5 cards):

Day of Judgment: Custom("Destroy all creatures.") → destroy_all("creatures")
Diregraf Ghoul: StaticEffect::Custom("Enters tapped.") → EntersTapped { filter: "self" }
Frenzied Goblin: Custom("Target creature can't block...") → CantBlock
Icewind Elemental: Custom("draw a card, then discard a card") → draw_cards(1), discard_cards(1)
Refute: Custom("Counter target spell. Draw a card...") → counter_spell(), draw_cards(1), discard_cards(1) + fixed targeting to TargetSpec::Spell

ECL (9 cards):

Brambleback Brute: Custom("can't block") → CantBlock
Blighted Blackthorn (x2): self -1/-1 counters → add_counters("-1/-1", 2)
Sourbread Auntie: self -1/-1 counters → add_counters("-1/-1", 2)
Sting-Slinger: self -1/-1 counter → add_counters("-1/-1", 1)
Heirloom Auntie, Encumbered Reejerey, Reluctant Dounguard, Bristlebane Battler: remove -1/-1 counter → RemoveCounters
Mistmeadow Council: ETB draw → draw_cards(1)

Results

246 tests pass (up from 245 — new self-counter test)
Updated work-queue.md, fdn-remediation.md, ecl-remediation.md, ROADMAP.md

GreppedCustom\("draw a card, then discard a card"\)

GreppedCustom\("When this creature enters, draw a card\."\)

Session command

Some patterns weren't found — line numbers shifted or text changed. Let me search more broadly for the remaining items.

GreppedDay of Judgment|DayOfJudgment

GreppedDiregraf Ghoul|DiregrafGhoul

GreppedFrenzied Goblin|FrenziedGoblin

GreppedSkoa Veteran|SkoaVeteran

Read docs/work-queue.md and do the next unchecked batch. For each batch:

Read the engine files (mtg-engine/src/abilities.rs, mtg-engine/src/game.rs) to understand current Effect/StaticEffect variants
If the batch has a NOTE about uncertainty, investigate first and update the queue with findings before committing the fix
If engine work is needed: add the variant, constructor, and match arm
Add a test for any new engine effect (follow the pattern in game.rs mod tests)
Fix all cards listed in the batch (grep to find exact lines, fix across all 4 set files)
cargo check -p mtg-cards && cargo test --lib
Update docs: mark cards in docs/{fdn,tla,tdm,ecl}-remediation.md, update ROADMAP.md
Check off the batch in docs/work-queue.md with today's date
If you discover new cards that fit the current or a future batch while working, add them to the queue

If a batch turns out to be wrong or more complex than described, update the queue with what you learned and move on to the next one.

Greppeddraw a card.*discard a card|loot

GreppedCustom.*draw a card

Let me get more context on the specific cards that need fixing.

Readfdn.rs15 lines

I'll start by reading the work queue to understand what's next.

Readfdn.rs25 lines

Readecl.rs20 lines

Greppedcan't block this turn

Readecl.rs30 lines

Good. Now let me also check the cards around ECL line 1438 (Sourbread Auntie) and line 1467 (Sting-Slinger). And I need to see how AddCounters is handled in game.rs. Let me also check the EntersTapped variant - it already exists in the StaticEffect enum with a filter field. Let me check what the card needs.

Actually, looking at the StaticEffect enum, EntersTapped has filter: String. For Diregraf Ghoul, we just need StaticEffect::EntersTapped { filter: "self".into() } or something. But wait, a static ability on the card itself that says "this enters tapped" - what filter should it use?

Now I need to check how EntersTapped is actually implemented in game.rs to understand the filter behavior.