Reviewed provider rename and changelog issues in PR

Summary

In Progress

Understand
Reviewed PR description, comments, commits, and changed files.
Understand
Understand
Checked linked issues and relevant source files.
Understand
Understand
Identified provider rename causing detection break.
Understand
Understand
Verified changelog entry placement and classification.
Understand

You are given one or more GitHub PR URLs: https://github.com/badlogic/pi-mono/pull/899/changes

For each PR URL, do the following in order:

Read the PR page in full. Include description, all comments, all commits, and all changed files.
Identify any linked issues referenced in the PR body, comments, commit messages, or cross links. Read each issue in full, including all comments.
Analyze the PR diff. Read all relevant code files in full with no truncation from the current main branch and compare against the diff. Do not fetch PR file blobs unless a file is missing on main or the diff context is insufficient. Include related code paths that are not in the diff but are required to validate behavior.
Check for a changelog entry in the relevant packages/*/CHANGELOG.md files. Report whether an entry exists. If missing, state that a changelog entry is required before merge and that you will add it if the user decides to merge. Follow the changelog format rules in AGENTS.md. Verify:
- Entry uses correct section (### Breaking Changes, ### Added, ### Fixed, etc.)
- External contributions include PR link and author: Fixed foo ([#123](https://github.com/badlogic/pi-mono/pull/123) by [@user](https://github.com/user))
- Breaking changes are in ### Breaking Changes, not just ### Fixed
Check if packages/coding-agent/README.md, packages/coding-agent/docs/.md, packages/coding-agent/examples/**/.md require modification. This is usually the case when existing features have been changed, or new features have been added.
Provide a structured review with these sections:
- Good: solid choices or improvements
- Bad: concrete issues, regressions, missing tests, or risks
- Ugly: subtle or high impact problems
Add Questions or Assumptions if anything is unclear.
Add Change summary and Tests.

Output format per PR: PR: Changelog:

... Good:
... Bad:
... Ugly:
... Questions or Assumptions:
... Change summary:
... Tests:
...

If no issues are found, say so under Bad and Ugly.

Let me check if there are any linked issues and read the relevant source files to validate the changes:

Readtypes.ts

Readstream.ts

Readenv-api-keys.ts

Readmodel-resolver.ts

ReadCHANGELOG.md50 lines

continue

ReadCHANGELOG.md60 lines

There's an issue: the env-api-keys.ts file still has the old zai key in the envMap, not zai-coding-plan. Let me verify by checking the current state on main:

Now I see the issue. The PR changes packages/ai/src/stream.ts but the actual env key mapping is in packages/ai/src/env-api-keys.ts. The diff shows stream.ts being changed, but that's outdated code. Let me check the current structure more carefully:

I see. The diff shows changes to stream.ts that don't exist on main. The PR is based on an outdated version of main. The getEnvApiKey function used to be in stream.ts but has since been moved to env-api-keys.ts.

Let me also check if the PR has missing package labels and review other aspects:

Readopenai-completions.ts50 lines

Now I have a clear picture. The detectCompat function in openai-completions.ts still uses provider === "zai" for detection. The PR needs to update this to provider === "zai-coding-plan".

Let me check the cross-provider-handoff test as mentioned in AGENTS.md:

Readcross-provider-handoff.test.ts120 lines

I notice the cross-provider-handoff test doesn't include zai (or zai-coding-plan). According to AGENTS.md, new providers should be added to this test.

Now let me check for documentation update requirements:

Readcustom-provider.md40 lines

The thinkingFormat description mentions "zai" which is correct as this is an internal format identifier, not the provider name.

Now let me check if there are any remaining issues to summarize:

This is a critical issue. The detectCompat function still checks for provider === "zai" but the PR renames the provider to zai-coding-plan. This will break detection for the new provider name.

Let me also verify the coding-agent changelog entry placement:

ReadCHANGELOG.md30 lines

I see. The PR has added a changelog entry under ## [0.49.2] - 2026-01-19 which is incorrect. The changelog entry should be under ## [Unreleased]. Additionally, the entry says "Changed" but this is a breaking change since it renames the provider.

Let me verify the exact diff for the coding-agent changelog:

Confirmed: the PR adds a changelog entry to a released version (0.49.2) instead of [Unreleased]. This is a violation of the changelog rules.

PR: https://github.com/badlogic/pi-mono/pull/899

Changelog:

packages/ai/CHANGELOG.md: Has entry under ## [Unreleased] → ### Breaking Changes ✅
packages/coding-agent/CHANGELOG.md: Entry incorrectly added under ## [0.49.2] (released version) instead of ## [Unreleased]. Must be moved. Also marked as ### Changed but should be ### Breaking Changes since renaming a provider breaks existing configurations.

Good:

Clear motivation in PR description and discussion leading to option 2 (simplify by removing ambiguity)
Consistent renaming across tests, README, model-resolver defaults, web-ui proxy-utils
Changelog entry exists in packages/ai/CHANGELOG.md with correct ### Breaking Changes section
Documentation updated in packages/coding-agent/README.md with detailed Z.AI Coding Plan notes
Tests updated to use the new provider name

Bad:

Critical: env-api-keys.ts not updated - The diff shows changes to stream.ts with an old getEnvApiKey function, but on main this function lives in packages/ai/src/env-api-keys.ts. The PR is based on an outdated main branch. The envMap in env-api-keys.ts still has zai: "ZAI_API_KEY" and needs to be changed to "zai-coding-plan": "ZAI_API_KEY".
Critical: detectCompat() in openai-completions.ts not updated - Line 754 still checks provider === "zai" but should check provider === "zai-coding-plan". Without this fix, the compatibility detection (thinking format, supportsStore, etc.) will fall back to defaults instead of detecting zai-specific settings.
Critical: KnownProvider type in types.ts not updated - The diff shows "zai-coding-plan" but main still has "zai". The PR needs rebasing.
Changelog entry in wrong section: packages/coding-agent/CHANGELOG.md entry added to released [0.49.2] instead of [Unreleased]
Missing pkg:* labels on the PR (should have pkg:ai, pkg:coding-agent, pkg:web-ui, pkg:agent)
Missing from cross-provider-handoff.test.ts: Per AGENTS.md, new providers should be added to this test

Ugly:

PR rebased on outdated main, causing phantom diffs (changes to stream.ts that don't exist on current main). This will cause merge conflicts and the key changes are missing.

Questions or Assumptions:

The PR will need rebasing on latest main before the actual changes can be applied correctly

Change summary:

Renames provider zai → zai-coding-plan to align with models.dev naming
Updates all tests, documentation, model generation, and web-ui components
Breaking change: existing users with ZAI_API_KEY configured will need to update their model selections from zai/... to zai-coding-plan/...

Tests:

Multiple test files updated with new provider name
Manual testing confirmed by contributor with GLM flash + thinking on/off
Missing: cross-provider-handoff.test.ts entry for zai-coding-plan provider