Fixed truncation message test failures

Summary

Closed, Completed

Understand
Investigated test failures and read tool behavior.
Understand
Understand
Reviewed truncation utility and git history.
Understand
Edit
Fixed regex in test expectations to match actual output.
Edit
Verify
Ran tests and full test suite to confirm fix.
Verify
Cleanup
Committed and pushed test fixes.
Cleanup

https://github.com/badlogic/pi-mono/actions/runs/21336434027 build fails, figure out why

The build is failing due to 4 test failures in packages/coding-agent/test/tools.test.ts. The tests are expecting truncation messages in the read tool output, but the read tool is returning raw content without the truncation hints. Let me look at the test file and the read tool implementation:

Readtools.test.ts150 lines

Readread.ts

Let me find the read tool:

Readread.ts

Now let me check the truncate utility to understand how truncation works:

Readtruncate.ts

Now I understand the issue. The tests expect truncation messages, but when looking at the read.ts code more closely, the condition for no truncation seems correct. Let me check if there was a recent change that broke this by looking at git history:

The recent commit added trailing periods to the messages, but the test expectations should have been updated. Let me check the test more closely:

Readtools.test.ts100 lines

I see. The tests expect the messages without the trailing period (. at the end), but the code was updated to include them. Let me look at the test expectations more closely:

The failures are:

should truncate files exceeding line limit - expects Use offset=2001 to continue] (no period)
should truncate when byte limit exceeded - expects Use offset=\d+ to continue] (the regex does have the period, so this one might be failing for another reason)
should handle limit parameter - expects Use offset=11 to continue] (no period)
should handle offset + limit together - expects Use offset=61 to continue] (no period)

Wait, looking at the git diff again, the recent commit 89636cfe added the trailing periods to the messages. But the tests didn't get updated. However, looking at the CI output:

→ expected 'Line 1\nLine 2\nLine 3\nLine 4\nLine …' to contain '[Showing lines 1-2000 of 2500. Use of…'

→ expected 'Line 1\nLine 2\nLine 3\nLine 4\nLine …' to contain '[Showing lines 1-2000 of 2500. Use of…'

This suggests the output doesn't contain ANY truncation message at all, not just a period mismatch. The file is returning all content without truncation. This is strange.

Let me run the test locally to see what's happening:

So the test is returning ALL lines (Line 1 through Line N) without any truncation. The truncation is not happening at all. Let me write a minimal test to debug this:

>cd packages/coding-agent && node -e "
const { truncateHead, DEFAULT_MAX_LINES, DEFAULT_MAX_BYTES } = require('./dist/core/tools/truncate.js');

// Test with 2500 lines
const lines = Array.from({ length: 2500 }, (_, i) => 'Line ' + (i + 1));
const content = lines.join('\\n');

console.log('Total lines:', lines.length);
console.log('DEFAULT_MAX_LINES:', DEFAULT_MAX_LINES);
console.log('DEFAULT_MAX_BYTES:', DEFAULT_MAX_BYTES);

const result = truncateHead(content);
console.log('Truncated:', result.truncated);
console.log('TruncatedBy:', result.truncatedBy);
console.log('OutputLines:', result.outputLines);
console.log('TotalBytes:', result.totalBytes);
" 2>&1

Good, the truncation function works correctly. The issue must be in how the read tool is using it. Let me check if the test is importing the right tool or something else is going on:

>cd packages/coding-agent && node -e "
const { readTool } = require('./dist/core/tools/read.js');
const fs = require('fs');
const os = require('os');
const path = require('path');

(async () => {
  // Create temp file
  const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'read-test-'));
  const testFile = path.join(testDir, 'large.txt');
  const lines = Array.from({ length: 2500 }, (_, i) => 'Line ' + (i + 1));
  fs.writeFileSync(testFile, lines.join('\\n'));
  
  console.log('Created file with', lines.length, 'lines');
  
  const result = await readTool.execute('test', { path: testFile });
  
  const textContent = result.content.filter(c => c.type === 'text').map(c => c.text).join('\\n');
  console.log('Output length:', textContent.length);
  console.log('Has truncation message:', textContent.includes('[Showing lines'));
  console.log('First 100 chars:', textContent.substring(0, 100));
  console.log('Last 200 chars:', textContent.substring(textContent.length - 200));
  
  // Cleanup
  fs.rmSync(testDir, { recursive: true, force: true });
})();
" 2>&1

Interesting! When I run this with the correct cwd handling via the dist file, it works. The issue is that the test imports readTool directly, which is created with process.cwd() at module load time. Let me check:

Readread.ts20 lines

Readread.ts30 lines

I see. The readTool is using process.cwd(). The test is passing absolute paths, so this should work. Wait, let me look at the test more carefully again:

Readtools.test.ts75 lines

The test is passing an absolute path (testFile) to readTool.execute. Since it's an absolute path, it should work regardless of cwd.

Let me check if there's something different in the import. The test imports from ../src/core/tools/read.js (TypeScript source), not from dist. Let me check if the code runs properly from source:

There are build errors in the project. This is unrelated to the test failure though since the test doesn't depend on those specific files.

Let me check if vitest is using the built dist files or the source files:

Readvitest.config.ts

Readtsconfig.json

Readtsconfig.build.json

Let me check the issue more carefully by looking at an actual run with debug:

>cd packages/coding-agent && npx tsx -e "
import { readTool } from './src/core/tools/read.js';
import { truncateHead, DEFAULT_MAX_LINES, DEFAULT_MAX_BYTES } from './src/core/tools/truncate.js';
import { mkdirSync, writeFileSync, rmSync } from 'fs';
import { tmpdir } from 'os';
import { join } from 'path';

console.log('DEFAULT_MAX_LINES:', DEFAULT_MAX_LINES);
console.log('DEFAULT_MAX_BYTES:', DEFAULT_MAX_BYTES);

// Create test file
const testDir = join(tmpdir(), 'coding-agent-test-' + Date.now());
mkdirSync(testDir, { recursive: true });
const testFile = join(testDir, 'large.txt');
const lines = Array.from({ length: 2500 }, (_, i) => 'Line ' + (i + 1));
writeFileSync(testFile, lines.join('\n'));

console.log('Created file:', testFile);
console.log('Total lines:', lines.length);

// Test truncateHead directly  
const content = lines.join('\n');
const truncResult = truncateHead(content);
console.log('\\nDirect truncateHead:');
console.log('  truncated:', truncResult.truncated);
console.log('  truncatedBy:', truncResult.truncatedBy);
console.log('  outputLines:', truncResult.outputLines);

// Test readTool
const result = await readTool.execute('test', { path: testFile });
const output = result.content.filter((c: any) => c.type === 'text').map((c: any) => c.text).join('\\n');

console.log('\\nreadTool result:');
console.log('  Output length:', output.length);
console.log('  Line count:', output.split('\\n').length);
console.log('  Has truncation message:', output.includes('[Showing lines'));
console.log('  details:', result.details);

// Cleanup
rmSync(testDir, { recursive: true, force: true });
" 2>&1

>cd packages/coding-agent && npx tsx -e "
import { readTool } from './src/core/tools/read.js';
import { truncateHead, DEFAULT_MAX_LINES, DEFAULT_MAX_BYTES } from './src/core/tools/truncate.js';
import { mkdirSync, writeFileSync, rmSync } from 'fs';
import { tmpdir } from 'os';
import { join } from 'path';

async function main() {
  console.log('DEFAULT_MAX_LINES:', DEFAULT_MAX_LINES);
  console.log('DEFAULT_MAX_BYTES:', DEFAULT_MAX_BYTES);

  // Create test file
  const testDir = join(tmpdir(), 'coding-agent-test-' + Date.now());
  mkdirSync(testDir, { recursive: true });
  const testFile = join(testDir, 'large.txt');
  const lines = Array.from({ length: 2500 }, (_, i) => 'Line ' + (i + 1));
  writeFileSync(testFile, lines.join('\n'));

  console.log('Created file:', testFile);
  console.log('Total lines:', lines.length);

  // Test truncateHead directly  
  const content = lines.join('\n');
  const truncResult = truncateHead(content);
  console.log('\nDirect truncateHead:');
  console.log('  truncated:', truncResult.truncated);
  console.log('  truncatedBy:', truncResult.truncatedBy);
  console.log('  outputLines:', truncResult.outputLines);

  // Test readTool
  const result = await readTool.execute('test', { path: testFile });
  const output = result.content.filter((c) => c.type === 'text').map((c) => c.text).join('\n');

  console.log('\nreadTool result:');
  console.log('  Output length:', output.length);
  console.log('  Line count:', output.split('\n').length);
  console.log('  Has truncation message:', output.includes('[Showing lines'));
  console.log('  details:', result.details);

  // Cleanup
  rmSync(testDir, { recursive: true, force: true });
}

main();
" 2>&1

Now I can see it clearly! The output does include the message [Showing lines 1-2000 of 2500. Use offset=2001 to continue.] (with a trailing period), but the test expects:

(without the period at the end)

This is the mismatch: the code was updated to add the period in commit 89636cfe, but the tests weren't updated.

The fix is to update the test expectations to include the trailing period. Let me fix the 4 failing tests:

Readtools.test.ts

Now I can see all the tests. I need to fix 4 tests by adding the trailing period:

Line 69: [Showing lines 1-2000 of 2500. Use offset=2001 to continue] → add . at end
Line 81: Already uses regex that includes the period, so it should pass
Line 108: [90 more lines in file. Use offset=11 to continue] → add . at end
Line 123: [40 more lines in file. Use offset=61 to continue] → add . at end

Editedtools.test.ts

Now let me run the tests to verify the fix:

There's one more test failing. Looking at the output, the actual message is:

But the regex expects:

The issue is that the regex is missing the trailing . before the closing bracket. Let me check the test:

Readtools.test.ts20 lines

I see. The regex currently ends with to continue\] but the actual output ends with to continue.] (with a period before the ]). Let me fix the regex:

Editedtools.test.ts

All tests pass now. Let me run the full test suite for the coding-agent package to make sure nothing else broke:

looks good commit and push,

Done. The fix updated 4 test expectations in packages/coding-agent/test/tools.test.ts to include the trailing period that was added to the read tool truncation messages in commit 89636cfe.