Reviewed and merged GitHub PR #1124

Summary

Closed, Completed

Understand
Read PR description, comments, commits, and changed files.
Understand
Understand
Reviewed linked issues and comments.
Understand
Understand
Analyzed PR diff and relevant code files.
Understand
Understand
Checked changelog and documentation for updates.
Understand
Edit
Merged PR, updated changelog, and added comment.
Edit

You are given one or more GitHub PR URLs: https://github.com/badlogic/pi-mono/pull/1124 ive already pulled the pr down into the active local branch

For each PR URL, do the following in order:

Read the PR page in full. Include description, all comments, all commits, and all changed files.
Identify any linked issues referenced in the PR body, comments, commit messages, or cross links. Read each issue in full, including all comments.
Analyze the PR diff. Read all relevant code files in full with no truncation from the current main branch and compare against the diff. Do not fetch PR file blobs unless a file is missing on main or the diff context is insufficient. Include related code paths that are not in the diff but are required to validate behavior.
Check for a changelog entry in the relevant packages/*/CHANGELOG.md files. Report whether an entry exists. If missing, state that a changelog entry is required before merge and that you will add it if the user decides to merge. Follow the changelog format rules in AGENTS.md. Verify:
- Entry uses correct section (### Breaking Changes, ### Added, ### Fixed, etc.)
- External contributions include PR link and author: Fixed foo ([#123](https://github.com/badlogic/pi-mono/pull/123) by [@user](https://github.com/user))
- Breaking changes are in ### Breaking Changes, not just ### Fixed
Check if packages/coding-agent/README.md, packages/coding-agent/docs/.md, packages/coding-agent/examples/**/.md require modification. This is usually the case when existing features have been changed, or new features have been added.
Provide a structured review with these sections:
- Good: solid choices or improvements
- Bad: concrete issues, regressions, missing tests, or risks
- Ugly: subtle or high impact problems
Add Questions or Assumptions if anything is unclear.
Add Change summary and Tests.

Output format per PR: PR: Changelog:

... Good:
... Bad:
... Ugly:
... Questions or Assumptions:
... Change summary:
... Tests:
...

If no issues are found, say so under Bad and Ugly.

Now let me read the relevant files in full to validate the changes:

Readsession-selector.ts

Readsession-manager.ts

Readsession-selector-search.ts

Now let me check the changelog:

ReadCHANGELOG.md

ReadREADME.md

Let me check the docs directory for any documentation that might need updating:

Let me check the keybindings.md and settings.md for any relevant sort mode references:

Readkeybindings.md30 lines

Now let me verify the current state of the local branch to ensure I have the PR changes:

/Users/badlogic/Desktop/Screenshot\ 2026-02-01\ at\ 01.00.13.png

works as intended, but the message number messes with indentation. propose a better layout for the message number, title, and time

ReadScreenshot 2026-02-01 at 01.00.13.png

I see the issue. The message count (60), (34), (245), etc. has variable width which causes the session titles to start at different horizontal positions. This creates a jagged, hard-to-scan appearance.

Layout Options:

Option 1: Right-align message count in a fixed-width column

   (60) have a look at this commit: https://github...     1d   (34) pull this into a local branch                     1d  (245) Issue: JSON serialization failure in tool...      1d  (119) read @packages/tui/src/tui.ts  then this...       1d

   (60) have a look at this commit: https://github...     1d   (34) pull this into a local branch                     1d  (245) Issue: JSON serialization failure in tool...      1d  (119) read @packages/tui/src/tui.ts  then this...       1d

Pad the count to a fixed width (e.g., 5 chars for (xxx)) so titles align.

Option 2: Move message count to the right side with the age

  have a look at this commit: https://github...      60  1d  pull this into a local branch                      34  1d  Issue: JSON serialization failure in tool...      245  1d

  have a look at this commit: https://github...      60  1d  pull this into a local branch                      34  1d  Issue: JSON serialization failure in tool...      245  1d

Age and count become a right-aligned metadata block. Titles all start at the same column.

Option 3: Compact message count after the title (before age)

  have a look at this commit: https://github...  (60) 1d  pull this into a local branch                  (34) 1d  Issue: JSON serialization failure in tool...  (245) 1d

  have a look at this commit: https://github...  (60) 1d  pull this into a local branch                  (34) 1d  Issue: JSON serialization failure in tool...  (245) 1d

Message count is part of the right-side metadata, keeping left alignment clean.

Recommendation: Option 2 or 3. Both keep titles aligned at the left edge, which is easier to scan. Option 2 is cleaner if you drop the parentheses; Option 3 keeps the visual distinction with parentheses.

The tree indentation for child sessions would stay consistent since the prefix (└─, ├─) comes before the title, not the count.

2 is good

I'll implement Option 2: move the message count to the right side alongside the age.

Readsession-selector.ts80 lines

Now I'll make the edit to move the message count to the right side:

Editedsession-selector.ts

The check passes. The infos are pre-existing in unrelated files. Let me verify the change looks correct:

Readsession-selector.ts50 lines

The change is complete. Now sessions will display like:

  have a look at this commit: https://github...      60 1d  pull this into a local branch                      34 1d  Issue: JSON serialization failure in tool...      245 1d

  have a look at this commit: https://github...      60 1d  pull this into a local branch                      34 1d  Issue: JSON serialization failure in tool...      245 1d

The message count is now on the right side before the age, and all session titles align at the same column.

ok, love it, commit, merge into main, close pr with a ocmment in my tone describing what we changed and thanking the contributor. make sure changelog has an entry

ReadCHANGELOG.md30 lines

EditedCHANGELOG.md

>cd /Users/badlogic/workspaces/pi-mono && git add packages/coding-agent/CHANGELOG.md packages/coding-agent/src/modes/interactive/components/session-selector.ts && git commit -m "feat(coding-agent): threaded sort mode and compact format for /resume

Adds 'Threaded' as a new sort mode (now default) that displays sessions
in a tree structure based on parent-child relationships. Compact one-line
format with message count and age right-aligned for clean title alignment.

Closes #1108"

>cd /Users/badlogic/workspaces/pi-mono && git checkout main && git pull --rebase && git merge pr-1124 --no-ff -m "feat(coding-agent): threaded sort mode and compact format for /resume (#1124)

Adds 'Threaded' as a new sort mode (now default) that displays sessions
in a tree structure based on parent-child relationships. Compact one-line
format with message count and age right-aligned for clean title alignment.

Closes #1108"

EditedCHANGELOG.md

>cd /Users/badlogic/workspaces/pi-mono && git add packages/coding-agent/CHANGELOG.md && git commit -m "feat(coding-agent): threaded sort mode and compact format for /resume (#1124)

Adds 'Threaded' as a new sort mode (now default) that displays sessions
in a tree structure based on parent-child relationships. Compact one-line
format with message count and age right-aligned for clean title alignment.

Closes #1108"

The PR was auto-closed when the commit referencing Closes #1108 was pushed. Let me add the comment:

Done. Merged PR #1124 with the layout fix (message count moved to right side), added changelog entry, pushed to main, and left a comment thanking @pasky.