thebigjc shared

Public

Fix Fight/Bite Mechanics and Targeting for CardsPublic

Agent

Claude Code

Model

Claude Opus 4.6

Shared

Feb 14, 7:03 PM

Messages532

Summary

Caveat: The messages below were generated by the user while running local commands. DO NOT respond to these messages or otherwise consider them in your response unless the user explicitly asks you to.

Caveat: Caveat: The messages below were generated by the user while running local commands. DO NOT respond to these messages or otherwise consider them in your response unless the user explicitly asks you to.

Session command

Read docs/work-queue.md and do the next unchecked batch. For each batch:

Read the engine files (mtg-engine/src/abilities.rs, mtg-engine/src/game.rs) to understand current Effect/StaticEffect variants
If the batch has a NOTE about uncertainty, investigate first and update the queue with findings before committing the fix
If engine work is needed: add the variant, constructor, and match arm, and look for the Java implementation to see the bigger picture
Add a test for any new engine effect (follow the pattern in game.rs mod tests)
Fix all cards listed in the batch (grep to find exact lines, fix across all 4 set files)
cargo check -p mtg-cards && cargo test --lib
Update docs: mark cards in docs/{fdn,tla,tdm,ecl}-remediation.md, update ROADMAP.md
Check off the batch in docs/work-queue.md with today's date
If you discover new cards that fit the current or a future batch while working, add them to the queue

If a batch turns out to be wrong or more complex than described, update the queue with what you learned and move on to the next one.

Let me start by reading the work queue to find the next unchecked batch.

Readwork-queue.md

The next unchecked batch is Batch 8: Fight/Bite mechanic. Let me read the engine files and investigate the cards that need this.

Readabilities.rs

Readgame.rs

Let me read game.rs in parts and search for the fight/bite cards.

Readgame.rs200 lines

mtg-rl/mtg-cards/src/sets/ecl.rs:1799:        abilities: vec![Ability::spell(id, vec![Effect::boost_until_eot(1, 0), Effect::Custom("It fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/ecl.rs:2173:            vec![Effect::Custom("Choose two: copy target Kithkin you control; target player creates 1/1 Kithkin token; target creature +3/+3 until EOT; target creature you control fights target creature an opponent controls.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:2307:                vec![Effect::Custom("Target creature you control deals damage equal to its power to target creature or planeswalker you don't control.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:3009:            vec![Effect::Custom("Choose one: Search for basic land; or target creature you control fights target creature you don't control.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:5254:                vec![Effect::Custom("When Affectionate Indrik enters the battlefield, you may have it fight target creature you don't control.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:6019:                vec![Effect::Custom("Put a +1/+1 counter on target creature you control. Then that creature deals damage equal to its power to target creature an opponent controls.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:6798:                vec![Effect::Custom("Target creature you control gets +X/+X until end of turn. Then it fights up to one target creature you don’t control.".into())],
mtg-rl/mtg-cards/src/sets/tdm.rs:1215:        abilities: vec![Ability::spell(id, vec![Effect::Custom("Double target creature's P/T, then it fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/tdm.rs:1231:        abilities: vec![Ability::spell(id, vec![Effect::add_p1p1_counters(1), Effect::Custom("Target creature you control fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/tdm.rs:1255:        abilities: vec![Ability::spell(id, vec![Effect::Custom("Target creature you control fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/tdm.rs:2995:                    vec![Effect::Custom("Target Dragon you control deals damage equal to its power to any target.".into())],

mtg-rl/mtg-cards/src/sets/ecl.rs:1796:    // Sorcery {1}{G}. Target creature +1/+0, then fights opponent's creature.
mtg-rl/mtg-cards/src/sets/ecl.rs:1799:        abilities: vec![Ability::spell(id, vec![Effect::boost_until_eot(1, 0), Effect::Custom("It fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/ecl.rs:2173:            vec![Effect::Custom("Choose two: copy target Kithkin you control; target player creates 1/1 Kithkin token; target creature +3/+3 until EOT; target creature you control fights target creature an opponent controls.".into())],
mtg-rl/mtg-cards/src/sets/tla.rs:91:    registry.register("Jet, Freedom Fighter", jet_freedom_fighter, "TLA");
mtg-rl/mtg-cards/src/sets/tla.rs:147:    registry.register("Treetop Freedom Fighters", treetop_freedom_fighters, "TLA");
mtg-rl/mtg-cards/src/sets/tla.rs:1338:fn jet_freedom_fighter(id: ObjectId, owner: PlayerId) -> CardData {
mtg-rl/mtg-cards/src/sets/tla.rs:1339:    CardData { id, owner, name: "Jet, Freedom Fighter".into(),
mtg-rl/mtg-cards/src/sets/tla.rs:1348:                    "When Jet, Freedom Fighter enters, trigger effect.",
mtg-rl/mtg-cards/src/sets/tla.rs:1352:                    "When Jet, Freedom Fighter dies, trigger effect.",
mtg-rl/mtg-cards/src/sets/tla.rs:2094:fn treetop_freedom_fighters(id: ObjectId, owner: PlayerId) -> CardData {
mtg-rl/mtg-cards/src/sets/tla.rs:2095:    CardData { id, owner, name: "Treetop Freedom Fighters".into(),
mtg-rl/mtg-cards/src/sets/tla.rs:2104:                    "When Treetop Freedom Fighters enters, trigger effect.",
mtg-rl/mtg-cards/src/sets/fdn.rs:163:    registry.register("Bite Down", bite_down, "FDN");
mtg-rl/mtg-cards/src/sets/fdn.rs:386:    registry.register("Arbiter of Woe", arbiter_of_woe, "FDN");
mtg-rl/mtg-cards/src/sets/fdn.rs:2301:fn bite_down(id: ObjectId, owner: PlayerId) -> CardData {
mtg-rl/mtg-cards/src/sets/fdn.rs:2303:    CardData { id, owner, name: "Bite Down".into(), mana_cost: ManaCost::parse("{1}{G}"),
mtg-rl/mtg-cards/src/sets/fdn.rs:3005:    // Sorcery for {G}. Choose one: search for basic land; or creature you control fights creature you don't.
mtg-rl/mtg-cards/src/sets/fdn.rs:3009:            vec![Effect::Custom("Choose one: Search for basic land; or target creature you control fights target creature you don't control.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:5252:                "When Affectionate Indrik enters the battlefield, you may have it fight target creature you don't control.",
mtg-rl/mtg-cards/src/sets/fdn.rs:5254:                vec![Effect::Custom("When Affectionate Indrik enters the battlefield, you may have it fight target creature you don't control.".into())],
mtg-rl/mtg-cards/src/sets/fdn.rs:5331:fn arbiter_of_woe(id: ObjectId, owner: PlayerId) -> CardData {
mtg-rl/mtg-cards/src/sets/fdn.rs:5332:    CardData { id, owner, name: "Arbiter of Woe".into(), mana_cost: ManaCost::parse("{4}{B}{B}"),
mtg-rl/mtg-cards/src/sets/fdn.rs:6798:                vec![Effect::Custom("Target creature you control gets +X/+X until end of turn. Then it fights up to one target creature you don’t control.".into())],
mtg-rl/mtg-cards/src/sets/tdm.rs:259:    registry.register("Teval, Arbiter of Virtue", teval_arbiter_of_virtue, "TDM");
mtg-rl/mtg-cards/src/sets/tdm.rs:1212:    // Sorcery {2/G}{2/U}{2/R}. Double P/T of your creature, then fight.
mtg-rl/mtg-cards/src/sets/tdm.rs:1215:        abilities: vec![Ability::spell(id, vec![Effect::Custom("Double target creature's P/T, then it fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/tdm.rs:1228:    // Sorcery {2}{G}. +1/+1 counter on your creature, then it fights opponent's creature.
mtg-rl/mtg-cards/src/sets/tdm.rs:1231:        abilities: vec![Ability::spell(id, vec![Effect::add_p1p1_counters(1), Effect::Custom("Target creature you control fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/tdm.rs:1252:    // Instant {1}{G}. Behold Dragon. Your creature fights target. If beheld, surveil 2.
mtg-rl/mtg-cards/src/sets/tdm.rs:1255:        abilities: vec![Ability::spell(id, vec![Effect::Custom("Target creature you control fights target creature you don't control.".into())], TargetSpec::Creature)],
mtg-rl/mtg-cards/src/sets/tdm.rs:3522:fn teval_arbiter_of_virtue(id: ObjectId, owner: PlayerId) -> CardData {
mtg-rl/mtg-cards/src/sets/tdm.rs:3523:    CardData { id, owner, name: "Teval, Arbiter of Virtue".into(),

Now I have a good picture of what needs to be done. Let me categorize the cards:

Fight cards (two creatures deal damage to each other equal to their power):

TDM: Teval, Arbiter of Virtue (line 1255) — "Target creature you control fights target creature you don't control."
TDM: line 1231 — "+1/+1 counter on your creature, then it fights opponent's creature."
TDM: line 1215 — "Double target creature's P/T, then it fights target creature you don't control."
ECL: line 1799 — "Target creature +1/+0, then fights opponent's creature."
FDN: Affectionate Indrik (line 5254) — "When Affectionate Indrik enters the battlefield, you may have it fight target creature you don't control."

One-way damage cards (creature deals damage without fighting back):
6. FDN: line 6019 — "Put a +1/+1 counter on target creature you control. Then that creature deals damage equal to its power to target creature an opponent controls."
7. FDN: line 3009 — Modal effect with fight option
8. FDN: Bite Down (line 2307) — "Target creature you control deals damage equal to its power to target creature or planeswalker you don't control."
9. TDM: line 2995 — "Target Dragon you control deals damage equal to its power to any target."

Now I'm cross-referencing the batch assignments with what I'm actually finding in the grep results. The work queue shows Bite Down and several fight cards for Batch 8, but I need to verify the exact line numbers and card names match up with what's in the codebase.

Looking through the fight mechanics more systematically, I'm seeing a range of implementations across the sets. There's the straightforward fight effect, variations with stat boosts applied before fighting, modal options that include fight as one choice, and some compound mechanics that layer multiple effects together. Some of these are marked as too complex for the current batch, so I need to identify which ones are actually doable and which ones should be deferred.

Let me get more context on each of these cards to understand their exact effects.

Readfdn.rs25 lines

Readecl.rs20 lines

Readtdm.rs50 lines

Readtdm.rs15 lines

Let me also check TLA for Earth Rumble and other fight cards mentioned in the work queue.

50:    registry.register("Earth Rumble", earth_rumble, "TLA");
51:    registry.register("Earth Rumble Wrestlers", earth_rumble_wrestlers, "TLA");
778:fn earth_rumble(id: ObjectId, owner: PlayerId) -> CardData {
779:    CardData { id, owner, name: "Earth Rumble".into(),
786:fn earth_rumble_wrestlers(id: ObjectId, owner: PlayerId) -> CardData {
787:    CardData { id, owner, name: "Earth Rumble Wrestlers".into(),

Readtla.rs25 lines

Earth Rumble has no abilities at all — it's a stub with no effects. Let me look at the Java source to see what it does.

Let me also look at what the Java implementation for fight/bite looks like to understand the pattern. But actually, for this Rust engine, I just need to add the Fight and Bite effect variants and implement them.

Let me think about what I can fix in this batch:

Simple fight cards (where I can replace Custom with Fight):

TDM: Piercing Exhale (line 1255) — pure fight: "Target creature you control fights target creature you don't control."
TDM: Knockout Maneuver (line 1231) — adds a +1/+1 counter then triggers a fight
ECL: Assert Perfection (line 1799) — boosts a creature by 1/0 until end of turn, then fights
FDN: Affectionate Indrik (line 5254) — triggers a fight when it enters the battlefield (optional)

Simple bite cards (one-way damage based on power):

FDN: Bite Down (line 2307) — deals damage equal to the creature's power to a target opponent's creature or planeswalker
FDN: Felling Blow (line 6019) — adds a +1/+1 counter then deals damage based on power

I'm setting aside the more complex ones for now: Dragonclaw Strike with its doubling mechanic, the Dragon-specific activated ability, Primal Might with its X-cost, the modal cards from later batches, and Earth Rumble which is still just a stub. Let me check what Earth Rumble actually does in the code.

Actually, Earth Rumble has no abilities implemented yet, so I can't work with it without more information. Let me focus on what I can actually build. I need to implement two core engine effects: Fight, where two creatures damage each other based on their power, and Bite, where a creature deals damage equal to its power to a target. Then I'll wire these into the effect execution system to find the source and target permanents and apply the damage accordingly.

The tricky part is handling Fight in spells, since it typically targets two different creatures—your creature and the opponent's—but our current targeting system doesn't cleanly support that. For ETB effects like Affectionate Indrik, the source creature is the permanent itself, which is simpler to handle.

I need to examine how the engine's target system actually works to figure out the best way to model this.

Let me look at how the engine handles execute_effects, especially how targets work.

Readgame.rs250 lines

Readgame.rs200 lines

Readgame.rs150 lines

Now I have a good understanding of the engine. Let me design the Fight and Bite effects.

Fight: Two creatures deal damage to each other equal to their respective powers.

In the engine context: the source creature (from source parameter) fights the target creature (from targets).
For spell-based fight cards like "target creature you control fights target creature you don't control", our simplified engine will:
- Use the source parameter for the "your creature" side (falls back to any controller's creature)
- Use targets for the opponent's creature
- Actually, this won't work because source is the spell itself, not a creature.

I need to reconsider how this maps to the engine. When a spell resolves, source is the spell's card ID, not a creature, and fight spells require two creature targets but our TargetSpec only supports selecting one. For the simplified approach, I'll treat the first creature (either from source or the first entry in targets) as one combatant and the remaining target as the other. For ETB triggers, source is the creature itself, so it fights the target. For spells, we need a different approach.

Looking at how the cards are currently set up:

ETB fight (Affectionate Indrik): trigger with TargetSpec::None currently, but should be TargetSpec::Creature (opponent's creature). The source permanent is the creature that fights.
Spell fight (Piercing Exhale, Knockout Maneuver): TargetSpec::Creature currently targets one creature, but they need two targets.

For a simplified engine approach:

For ETB/triggered fight: Source is the creature. Target is opponent's creature. We deal source_power damage to target and target_power damage to source.
For spell fight: We pick the first creature controlled by the spell controller, and it fights the target

Since we don't have proper two-target support yet, I can work around this by checking the targets list — if the first target is controlled by the spell's controller, that's the creature doing the fighting, otherwise I'll look for the first available creature they control to use instead. for the controller's strongest creature

Hmm, this is getting complicated. Let me just use a simple approach:

For Fight:

If source is on the battlefield (it's a creature), source fights target[0]
If source is NOT on the battlefield (it's a spell), pick the strongest creature the controller has and fight target[0]

For Bite:

Same logic but one-way: source creature (or controller's strongest) deals its power as damage to target

Looking at the specific cards, I see the pattern now. Most of these are spells that target one of your creatures and one of your opponent's creatures. The spell gives your creature a boost, then they fight. For the implementation, I need to identify which target belongs to the spell controller and which doesn't, apply any buffs first, then resolve the fight or damage effect. I need to figure out the targeting logic by looking at how existing fight cards are set up. Let me check Piercing Exhale and Knockout Maneuver to see if they're using a single target or multiple targets, since that'll determine whether I need to infer the fighting creature or if it's already specified. I'm settling on a consistent approach for how Fight and Bite effects resolve: the source creature fights if it's on the battlefield, otherwise we pick the controller's strongest creature, and that creature battles the targeted opponent's creature. For the card implementations, I need to adjust the targeting and effect logic to match this framework. I'm realizing the counter placement is the tricky part here. The AddCounters effect has a source fallback, but for a spell that's the card itself, not a creature on the battlefield. For these compound spell-fight cards, I think the cleanest solution is to have the Fight effect handle putting the counter on your creature as part of its logic, rather than trying to manage two separate targets. I'm realizing the core issue: AddCounters targets either targets[0] or the spell source, but for compound fight cards like Knockout Maneuver, I need the counter to apply to the creature doing the fighting, not the target. The simplest fix is to drop the counter modeling entirely for these cards and just use the Fight effect, accepting it as a limitation of our simplified engine.

Let me categorize what I'm dealing with: pure fight spells like Piercing Exhale, fight triggers on creatures, compound cards that buff before fighting (Knockout Maneuver, Assert Perfection), and pure damage effects like Bite Down. For Assert Perfection specifically, the boost is already modeled as a temporary effect on the target creature, so I need to figure out how to chain that with the fight.

The issue is that Assert Perfection targets your own creature to buff it, then fights with that creature against an opponent's creature, while Piercing Exhale targets an opponent's creature to fight it. This inconsistency in what "target" means between different cards suggests I need a more flexible approach in the engine—either distinguishing between source and target creatures in fight effects, or handling spell-based fights differently from ETB-triggered fights. me look at this from a targeting perspective. I can introduce a new TargetSpec for two creatures:

TargetSpec::Multiple { spec: Box<TargetSpec::Creature>, count: 2 }

But that doesn't distinguish between "your creature" and "opponent's creature".

OK, ultimate pragmatic approach:

Effect::Fight: The source creature (from source or auto-selected from controller's creatures) fights the first target creature. If source is on the battlefield and is a creature, use it. Otherwise, pick controller's strongest creature. The target in targets[0] is the opponent's creature that gets fought.

Effect::Bite: Same logic but one-way damage.

For compound cards, I'll keep things simple: Knockout Maneuver uses Effect::Fight with TargetSpec::Creature for the opponent's creature, dropping the +1/+1 counter. Assert Perfection needs the boost applied to my creature before the fight happens, but that requires proper two-target support which is a bigger engine change. For now, I'm going to implement Effect::Fight and Effect::Bite variants, handle ETB triggers where the source is the creature and target is the opponent's creature, and support pure fight spells that auto-select my strongest creature against the opponent's target. I'm realizing these compound spells were already simplified in the implementation, so I shouldn't overcomplicate this. For the Fight effect, I'll have it find the controller's strongest creature as the fighter, then target the opponent's creature from the targets list, and if neither exists I'll fall back to a sensible default.

For Bite, it's the same targeting logic but only deals one-way damage. Then I can fix the three cards by assigning them the right effect combinations—Piercing Exhale gets Fight directly, while Knockout Maneuver and Assert Perfection each get their boost or counter effect followed by Fight, all using creature targeting.

Wait, I need to reconsider Knockout Maneuver—the counter and the fight target are actually the same creature, the one you control, so the implementation should reflect that the counter applies to the creature doing the fighting.

The issue is that Fight needs both creatures but our simplified system only tracks one target. I think the cleanest solution is to have Fight auto-select both combatants using a heuristic: your strongest creature as the attacker and the opponent's strongest creature as the defender, completely bypassing the targets array. This keeps the logic simple and handles all the edge cases consistently.

But wait—for something like Bite Down, the player actually chooses which of their creatures does the biting, so auto-selecting the strongest one breaks that player agency. I need to reconsider this approach.

Let me think through the implementation more carefully. If a card has a target spec for the creature doing the fighting or biting, I should use that target when it's available. For effects without explicit targets, defaulting to the strongest creature is reasonable for a simplified engine. So I'll check whether targets exist first, and only fall back to auto-selection when needed.

Now I'm looking at which cards to update in this pass. I'll handle Bite Down and Affectionate Indrik with the new effects, but I'm skipping the Dragon damage card since it has custom targeting logic that doesn't fit the pattern. Looking at what still needs to be implemented, I see several cards requiring X-cost mechanics and modal abilities that haven't been tackled yet, plus I need to investigate what Earth Rumble actually does since it's currently just a stub.

Now I have a full picture. Let me check Earth Rumble's Java source and read the existing test patterns.

Readgame.rs200 lines

Let me check how Permanent::power() and apply_damage() work.

Readpermanent.rs25 lines

Readpermanent.rs20 lines

Good. Now I have everything I need. Let me implement the batch. I'll:

Add Effect::Fight and Effect::Bite variants + constructors
Add match arms in execute_effects
Add a test
Fix the cards
Verify with cargo check and cargo test

Let me start with the engine changes.

Now add the constructors:

Now add the match arms in execute_effects in game.rs. I'll add them right before the _ => catch-all.

Now I need to add the helper methods find_fight_creature and find_fight_target. Let me add them near the other helper methods like matches_filter.

Readgame.rs30 lines

Readgame.rs60 lines

Now I'll add the fight helper methods right after card_matches_filter:

Now let me add the test. I'll add it right before the closing } of the tests module:

Readgame.rs10 lines

Now let me check that the engine compiles before fixing cards:

Engine compiles. Now let me fix the cards. Let me fix them all with sed:

Tests pass. Now let me fix the cards. Let me fix each one:

1. FDN: Bite Down — pure bite spell

2. FDN: Affectionate Indrik — ETB fight trigger

Readfdn.rs15 lines

Wait, sed replacing TargetSpec::None), could hit many places. Let me check.

That sed replaced ALL TargetSpec::None), with TargetSpec::Creature), — that's a disaster. Let me undo that.

Let me be much more careful with the edits. I'll use specific context in sed or read/edit individual cards.

Now for Affectionate Indrik, I need to change both the Effect and the TargetSpec on surrounding lines. Let me use a more precise approach:

Readfdn.rs10 lines

3. FDN: Felling Blow — +1/+1 counter + bite

Readfdn.rs12 lines

4. ECL: Assert Perfection — boost + fight

Readecl.rs8 lines

5. TDM: Piercing Exhale — pure fight

That should have fixed both Piercing Exhale (pure fight) and Knockout Maneuver (counter + fight). Let me verify:

Lines 1231 (Knockout Maneuver) and 1255 (Piercing Exhale) are fixed. Dragonclaw Strike (1215) is still Custom (expected — it has "double P/T" which we can't implement).

Now let me check if there are any remaining fight customs to handle:

Good. The remaining ones are:

FDN: "Choose one..." — modal (Batch 11)
FDN: Primal Might — X-cost (Batch 15)
ECL: "Choose two..." — modal (Batch 11)
TDM: Dragonclaw Strike — double P/T (too complex)
TDM: Dragon land — bite with dragon-specific targeting (custom target)

These are all correctly deferred. Let me compile and test:

All 252 tests pass. Now let me update the documentation. First, let me update the work queue:

Readwork-queue.md20 lines

Now update the per-set remediation docs. Let me check the current state of the remediation docs for the affected cards:

Now let me check for Affectionate Indrik and Felling Blow in fdn-remediation.md:

Now update ROADMAP.md:

59:#### Fight/Bite Mechanic
61:- **Blocked cards:** Bite Down, Earth Rumble, Knockout Maneuver, Piercing Exhale, Dragonclaw Strike, Assert Perfection (~10+ cards)
136:   - ~~Burglar Rat/Dream Seizer/Arbiter of Woe/Bloodtithe Collector: opponent discard Custom -> `DiscardOpponents { count }`~~ **DONE**
138:3. **Fight mechanic** -- New `Effect::Fight` variant. Two creatures deal damage equal to their power to each other. Unblocks ~10 cards.

ReadROADMAP.md15 lines

Now update the "next batches" section in the roadmap:

ReadROADMAP.md15 lines

Let me verify the fixes are all correct by re-checking the modified card lines:

200 of 532