Public

Fix Fight/Bite Mechanics and Targeting for CardsPublic

The user aimed to implement and fix the fight and bite mechanics for certain cards, ensuring they matched the behavior in the original Java version. They corrected targeting logic to allow explicit target selection, fixed effect types on several cards, and adjusted compound effects to apply correctly. After thorough testing and documentation updates, all changes passed validation and aligned with the intended game mechanics.

Agent

Claude Code

Model

Claude Opus 4.6

Shared

Feb 14, 7:03 PM

Messages532

Session command

Read docs/work-queue.md and do the next unchecked batch. For each batch:

Read the engine files (mtg-engine/src/abilities.rs, mtg-engine/src/game.rs) to understand current Effect/StaticEffect variants
If the batch has a NOTE about uncertainty, investigate first and update the queue with findings before committing the fix
If engine work is needed: add the variant, constructor, and match arm, and look for the Java implementation to see the bigger picture
Add a test for any new engine effect (follow the pattern in game.rs mod tests)
Fix all cards listed in the batch (grep to find exact lines, fix across all 4 set files)
cargo check -p mtg-cards && cargo test --lib
Update docs: mark cards in docs/{fdn,tla,tdm,ecl}-remediation.md, update ROADMAP.md
Check off the batch in docs/work-queue.md with today's date
If you discover new cards that fit the current or a future batch while working, add them to the queue

If a batch turns out to be wrong or more complex than described, update the queue with what you learned and move on to the next one.

Let me start by reading the work queue to find the next unchecked batch.

Readwork-queue.md

The next unchecked batch is Batch 8: Fight/Bite mechanic. Let me read the engine files and investigate the cards that need this.

Readabilities.rs

Readgame.rs

GreppedFight|Bite|fight|bite

GreppedCustom\(.*[Ff]ight|Custom\(.*deals damage equal to its power|Custom\(.*each deal damage|Custom\(.*target creature deals damage

Let me read game.rs in parts and search for the fight/bite cards.

Readgame.rs200 lines

GreppedCustom\(.*[Ff]ight|Custom\(.*deals damage equal to its power|Custom\(.*each deal damage|Custom\(.*target creature deals damage

Greppedfight|Fight|bite|Bite

Let me get more context on each of these cards to understand their exact effects.

Readfdn.rs25 lines

Readecl.rs20 lines

Readtdm.rs50 lines

Readtdm.rs15 lines

Let me also check TLA for Earth Rumble and other fight cards mentioned in the work queue.

GreppedEarth Rumble|earth_rumble

GreppedCustom\(.*fight|Custom\(.*deals damage equal

Readtla.rs25 lines

Let me look at how the engine handles execute_effects, especially how targets work.

Greppedfn execute_effects

Readgame.rs250 lines

Readgame.rs200 lines

Readgame.rs150 lines

Now I have a full picture. Let me check Earth Rumble's Java source and read the existing test patterns.

Greppedclass EarthRumble

Readgame.rs200 lines

Greppedfn boost_all_and_grant_keyword|fn discard_opponents_effect|fn add_counters_self_when_no_targets|fn framework_create_token

Readgame.rs200 lines

Let me check how Permanent::power() and apply_damage() work.

Greppedpub fn power|pub fn apply_damage|fn is_creature

Readpermanent.rs25 lines

Readpermanent.rs20 lines

Good. Now I have everything I need. Let me implement the batch. I'll:

Add Effect::Fight and Effect::Bite variants + constructors
Add match arms in execute_effects
Add a test
Fix the cards
Verify with cargo check and cargo test

Let me start with the engine changes.

Now add the constructors:

Now add the match arms in execute_effects in game.rs. I'll add them right before the _ => catch-all.

Now I need to add the helper methods find_fight_creature and find_fight_target. Let me add them near the other helper methods like matches_filter.

Readgame.rs30 lines

Greppedfn matches_filter\(perm

Readgame.rs60 lines

Now I'll add the fight helper methods right after card_matches_filter:

Now let me add the test. I'll add it right before the closing } of the tests module:

Greppedassert!\(!game.state.battlefield.get\(opp_bear_id\)

Readgame.rs10 lines

Now let me check that the engine compiles before fixing cards:

Engine compiles. Now let me fix the cards. Let me fix them all with sed:

Tests pass. Now let me fix the cards. Let me fix each one:

1. FDN: Bite Down — pure bite spell

2. FDN: Affectionate Indrik — ETB fight trigger

Readfdn.rs15 lines

Wait, sed replacing TargetSpec::None), could hit many places. Let me check.

That sed replaced ALL TargetSpec::None), with TargetSpec::Creature), — that's a disaster. Let me undo that.

Let me be much more careful with the edits. I'll use specific context in sed or read/edit individual cards.

Now for Affectionate Indrik, I need to change both the Effect and the TargetSpec on surrounding lines. Let me use a more precise approach:

Readfdn.rs10 lines

3. FDN: Felling Blow — +1/+1 counter + bite

Readfdn.rs12 lines

4. ECL: Assert Perfection — boost + fight

Readecl.rs8 lines

5. TDM: Piercing Exhale — pure fight

That should have fixed both Piercing Exhale (pure fight) and Knockout Maneuver (counter + fight). Let me verify:

Lines 1231 (Knockout Maneuver) and 1255 (Piercing Exhale) are fixed. Dragonclaw Strike (1215) is still Custom (expected — it has "double P/T" which we can't implement).

Now let me check if there are any remaining fight customs to handle:

Good. The remaining ones are:

FDN: "Choose one..." — modal (Batch 11)
FDN: Primal Might — X-cost (Batch 15)
ECL: "Choose two..." — modal (Batch 11)
TDM: Dragonclaw Strike — double P/T (too complex)
TDM: Dragon land — bite with dragon-specific targeting (custom target)

These are all correctly deferred. Let me compile and test:

All 252 tests pass. Now let me update the documentation. First, let me update the work queue:

Readwork-queue.md20 lines

Now update the per-set remediation docs. Let me check the current state of the remediation docs for the affected cards:

GreppedBite Down|Affectionate Indrik|Felling Blow

GreppedAssert Perfection

GreppedPiercing Exhale|Knockout Maneuver

Now let me check for Affectionate Indrik and Felling Blow in fdn-remediation.md:

GreppedAffectionate Indrik|Felling Blow

Now update ROADMAP.md:

Greppedfight|Fight|bite|Bite

ReadROADMAP.md15 lines

Now update the "next batches" section in the roadmap:

ReadROADMAP.md15 lines

Let me verify the fixes are all correct by re-checking the modified card lines:

200 of 532