Srihari Sriraman shared in

Public

Fixed multi-file extension discoveryPublic

Agent

Model

Claude Opus 4.5 (latest)

Started

Jan 30, 10:44 PM

Messages136

Downloads0

Summary

Closed, Completed

Understand
Reviewed GitHub issue and related code.
Understand
Build
Implemented fix for extension discovery.
Build
Verify
Ran tests to confirm fix.
Verify
Cleanup
Released new version and closed issue.
Cleanup

Analyze GitHub issue(s): https://github.com/badlogic/pi-mono/issues/1102

For each issue:

Read the issue in full, including all comments and linked issues/PRs.
For bugs:
- Ignore any root cause analysis in the issue (likely wrong)
- Read all related code files in full (no truncation)
- Trace the code path and identify the actual root cause
- Propose a fix
For feature requests:
- Read all related code files in full (no truncation)
- Propose the most concise implementation approach
- List affected files and changes needed

Do NOT implement unless explicitly asked. Analyze and propose only.

Let me find the relevant extension loading code:

Let me examine the specific functions that handle extension collection:

Now I understand the root cause. Let me verify by looking at the specific sections:

Now let me check the collectFilesFromPaths function that's also relevant:

Analysis Summary

Issue #1102: Packaged extensions discover files differently than local extensions

Type: Bug

Labels: bug, should add pkg:coding-agent

Root Cause

The bug is in packages/coding-agent/src/core/package-manager.ts. There are two different code paths for discovering extension files:

Auto-discovery (local directories) uses collectAutoExtensionEntries() which properly handles multi-file extensions:
- Top-level .ts/.js files → loaded directly
- Subdirectories → calls resolveExtensionEntries() which finds only index.ts/index.js or explicit manifest entries
- Helper modules inside subdirectories are correctly ignored

Package resolution uses collectFiles() which recursively collects ALL .ts/.js files, including helper modules:

When collectFiles is used for extensions, every .ts file in the package's extensions/ directory gets loaded as a standalone extension, including helper modules like agents.ts that don't export a factory function.

Affected Locations (4 places using the wrong function)

Method	Line	Current	Should Use
`collectPackageResources`	~1216	`collectFiles()`	`collectAutoExtensionEntries()`
`collectDefaultResources`	~1242	`collectFiles()`	`collectAutoExtensionEntries()`
`collectManifestFiles`	~1301	`collectFiles()`	`collectAutoExtensionEntries()`
`collectFilesFromPaths`	~1501	`collectFiles()`	`collectAutoExtensionEntries()`

Proposed Fix

Create a helper function and use it consistently:

typescript

function collectResourceFiles(dir: string, resourceType: ResourceType): string[] {  if (resourceType === "skills") {    return collectSkillEntries(dir);  }  if (resourceType === "extensions") {    return collectAutoExtensionEntries(dir);  }  return collectFiles(dir, FILE_PATTERNS[resourceType]);}

Then replace all four occurrences of the ternary with collectResourceFiles(dir, resourceType).

Files to Modify

packages/coding-agent/src/core/package-manager.ts (4 edits)
packages/coding-agent/CHANGELOG.md (add entry under [Unreleased] → Fixed)

shouldn't auto collection be the same for packages and local paths in ~/.pi/agent and .pi/?

Yes, exactly. That's precisely what the fix does.

The bug exists because there are two different functions being used:

Local paths (~/.pi/agent/extensions/, .pi/extensions/): uses collectAutoExtensionEntries()
Packages: uses collectFiles() (recursive, grabs everything)

The fix unifies them so packages also use collectAutoExtensionEntries(), making the behavior identical:

Location	Entry Type	Behavior
`foo.ts`	File	Load it
`bar/index.ts`	Subdirectory with index	Load only `index.ts`
`bar/helper.ts`	Helper module	Ignored (imported by index.ts)
`baz/package.json` with `pi.extensions`	Subdirectory with manifest	Load declared entries

This should work the same whether the extension is in:

~/.pi/agent/extensions/
.pi/extensions/
A git/npm package's extensions/ directory

ok, but we only use that if no manifest is given, correct?

Correct. Looking at the code flow:

With manifest (package.json has pi.extensions): Uses the explicit paths declared in the manifest - collectAutoExtensionEntries is not involved
Without manifest: Falls back to convention-based discovery (looks for extensions/ directory) - this is where the bug occurs and where collectAutoExtensionEntries should be used

The workaround in the issue confirms this:

This works because the manifest path is used directly, bypassing the buggy collectFiles() fallback.

The fix only affects packages that rely on convention-based discovery (no manifest, or manifest without explicit extensions field).

ok, apply the fix, also add a regression test so this shit never happens again

Now I'll apply the fix and add the regression test:

Now let me add the regression test:

Now let's run the tests:

All tests pass. Let me run the full check:

Now let me update the changelog:

Let me verify the fix by checking the updated code:

Done. Here's a summary of the changes:

Summary

Files modified:

packages/coding-agent/src/core/package-manager.ts - Fixed extension discovery
packages/coding-agent/test/package-manager.test.ts - Added regression tests
packages/coding-agent/CHANGELOG.md - Added changelog entry

The fix:

Added a collectResourceFiles() helper function that routes to the correct collection function based on resource type:

typescript

function collectResourceFiles(dir: string, resourceType: ResourceType): string[] {  if (resourceType === "skills") {    return collectSkillEntries(dir);  }  if (resourceType === "extensions") {    return collectAutoExtensionEntries(dir);  // Uses smart discovery  }  return collectFiles(dir, FILE_PATTERNS[resourceType]);}

Replaced 4 occurrences where collectFiles() was incorrectly used for extensions.

Regression tests added (4 tests):

Only loads index.ts from subdirectories, not helper modules
Respects package.json pi.extensions manifest in subdirectories
Handles mixed top-level files and subdirectories correctly
Skips subdirectories without index.ts or manifest

run the test, if it passes:

commit & push comment on issue "Thanks for reporting, fixed on main" patch release

Tests pass. Committing and pushing:

Done. Released v0.50.7 with the fix:

Commit: ed80ab21 - fix(coding-agent): multi-file extensions in packages now discovered correctly
Issue #1102: Closed (auto-closed by commit message fixes #1102)
Published: @mariozechner/pi-coding-agent@0.50.7 and all other packages