Analyzed GitHub issue #844 for root cause andPublic

Agent

Model

GPT-5.2 Codex

Started

Jan 19, 1:19 PM

Messages51

Downloads0

Summary

In Progress

Understand
Reviewed issue #844 and related comments.
Understand
Understand
Examined all related code files in full.
Understand
Understand
Traced code paths for model selection and session handling.
Understand
Plan
Proposed a fix approach based on root cause analysis.
Plan

For each issue:

Read the issue in full, including all comments and linked issues/PRs.
For bugs:
- Ignore any root cause analysis in the issue (likely wrong)
- Read all related code files in full (no truncation)
- Trace the code path and identify the actual root cause
- Propose a fix
For feature requests:
- Read all related code files in full (no truncation)
- Propose the most concise implementation approach
- List affected files and changes needed

Do NOT implement unless explicitly asked. Analyze and propose only.

Issue 844 analysis

Type: bug

Linked issues or PRs: none.

What happens in code

/scoped-models persists the selection via SettingsManager.setEnabledModels in packages/coding-agent/src/modes/interactive/interactive-mode.ts.
On startup, packages/coding-agent/src/main.ts uses parsed.models ?? settingsManager.getEnabledModels() to build scopedModels via resolveModelScope.
createAgentSession receives scopedModels, and AgentSession stores them in _scopedModels.
/model uses session.scopedModels to build the candidate list in:
- packages/coding-agent/src/modes/interactive/interactive-mode.ts: getModelCandidates and autocomplete
- packages/coding-agent/src/modes/interactive/components/model-selector.ts: loadModels and hint text
Result: any persisted /scoped-models selection is treated like a --models scope, so /model only shows the scoped set and shows the “Showing models from --models scope” hint.

Actual root cause The same scopedModels list is used for two different purposes:

Ctrl+P cycling scope.
/model selector filtering and autocomplete. Persisted /scoped-models preferences are loaded as scopedModels on startup, so /model is unintentionally filtered.

Proposed fix Separate “cycling scope” from “model selector scope”.

Concise implementation approach

Add a scoped model source flag, for example:
- AgentSession: modelScopeSource: "cli" | "settings" | "session" | "none"
- or a boolean isModelSelectionScoped.
Set it in main.ts when building scopedModels:
- parsed.models set to cli
- settingsManager.getEnabledModels set to settings
- /scoped-models session-only updates set to session.
Update /model selector and autocomplete to only filter when scope source is cli.
Keep Ctrl+P cycling based on scoped models regardless of scope source.
Update hint text in ModelSelectorComponent to only show “Showing models from --models scope” for CLI scope. When scope source is settings or session, show a neutral hint like “Model cycling is scoped. /scoped-models to edit” or keep the existing API key hint.

Affected files and changes

packages/coding-agent/src/main.ts
- Track scope source when building scopedModels from CLI or settings.
packages/coding-agent/src/core/agent-session.ts
- Store scope source or isModelSelectionScoped.
- Expose a getter for InteractiveMode to decide selector behavior.
packages/coding-agent/src/modes/interactive/interactive-mode.ts
- getModelCandidates and autocomplete to use full registry unless scope source is CLI.
- showModelsSelector keeps setting scopedModels for cycling only.
packages/coding-agent/src/modes/interactive/components/model-selector.ts
- List full models unless scope source is CLI.
- Update hint text accordingly.

This keeps /scoped-models as a Ctrl+P preference while preserving --models as a hard scope for /model when explicitly requested.