Merged and verified text editing features PRPublic

Agent

Model

GPT-5.2 Codex

Started

Jan 17, 8:01 PM

Messages134

Downloads0

Summary

In Progress

Understand
Reviewed PR details, comments, and code changes.
Understand
Edit
Merged feature branch into main and pushed to origin.
Edit
Verify
Confirmed presence of changes on local main branch.
Verify

https://github.com/badlogic/pi-mono/pull/810

You are given one or more GitHub PR URLs: https://github.com/badlogic/pi-mono/pull/810

For each PR URL, do the following in order:

Read the PR page in full. Include description, all comments, all commits, and all changed files.
Identify any linked issues referenced in the PR body, comments, commit messages, or cross links. Read each issue in full, including all comments.
Analyze the PR diff. Read all relevant code files in full with no truncation from the current main branch and compare against the diff. Do not fetch PR file blobs unless a file is missing on main or the diff context is insufficient. Include related code paths that are not in the diff but are required to validate behavior.
Check for a changelog entry in the relevant packages/*/CHANGELOG.md files. Report whether an entry exists. If missing, state that a changelog entry is required before merge and that you will add it if the user decides to merge. Follow the changelog format rules in AGENTS.md. Verify:
- Entry uses correct section (### Breaking Changes, ### Added, ### Fixed, etc.)
- External contributions include PR link and author: Fixed foo ([#123](https://github.com/badlogic/pi-mono/pull/123) by [@user](https://github.com/user))
- Breaking changes are in ### Breaking Changes, not just ### Fixed
Check if packages/coding-agent/README.md, packages/coding-agent/docs/.md, packages/coding-agent/examples/**/.md require modification. This is usually the case when existing features have been changed, or new features have been added.
Provide a structured review with these sections:
- Good: solid choices or improvements
- Bad: concrete issues, regressions, missing tests, or risks
- Ugly: subtle or high impact problems
Add Questions or Assumptions if anything is unclear.
Add Change summary and Tests.

Output format per PR: PR: Changelog:

... Good:
... Bad:
... Ugly:
... Questions or Assumptions:
... Change summary:
... Tests:
...

If no issues are found, say so under Bad and Ugly.

PR: https://github.com/badlogic/pi-mono/pull/810
Changelog:

Missing entry in packages/tui/CHANGELOG.md for kill ring support, Alt+D delete word forward, and legacy Alt+letter handling. This should be under ### Added with external attribution to #810 by @Perlence.
Missing entry in packages/coding-agent/CHANGELOG.md for new editor hotkeys exposed in /hotkeys. Add under ### Added with external attribution.

Good:

Solid kill ring implementation with clear tests covering yank, yank-pop, and accumulation behaviors.
Legacy Alt+letter handling fills a practical gap for non-Kitty terminals and is covered in keys tests.

Bad:

Editor yank does not exit history mode. insertYankedText does not set historyIndex = -1, so a yank while browsing history keeps history mode active even though other edit actions exit it. This is inconsistent with insert, paste, and delete actions.
User-facing docs are out of date. packages/coding-agent/README.md does not list deleteWordForward, yank, or yankPop in Keyboard Shortcuts or Custom Keybindings.

Ugly:

None.

Questions or Assumptions:

Should Ctrl+Y be treated as an edit that exits prompt history mode, consistent with insert, paste, and delete actions? If yes, update insertYankedText or yank to reset historyIndex.

Change summary:

Adds kill ring support in the TUI editor, new yank and yank-pop bindings, delete word forward on Alt+D, and legacy Alt+letter matching.
Updates /hotkeys output to include new actions.

Tests:

Not run (not requested).

wtf, i don't undersatnd what a kill-ring is. explain to me

A kill ring is a clipboard history for deletions. When you use delete commands like Ctrl+W (delete word), Ctrl+U (delete to line start), Ctrl+K (delete to line end), the removed text is stored in a ring. Ctrl+Y pastes the most recent deletion. Alt+Y rotates backward through earlier deletions after a paste so you can replace the pasted text with previous entries.

In this PR, the editor records consecutive deletions as one entry, then Ctrl+Y restores it. Alt+Y cycles through older deletions if you just yanked.

is any additional ui shown for this crap? like how would i know if i cycle through older deletions?

No additional UI. It behaves like Emacs or readline. Ctrl+Y inserts the latest deletion. Alt+Y immediately replaces that inserted text with the next older entry. You can see the change in the editor content. If you do any other action after Ctrl+Y, Alt+Y stops working until you yank again.

ok, looks good to merge then?

Not ready yet. Missing changelog entries for packages/tui and packages/coding-agent, and README needs keyboard shortcut updates. Also there is the history mode mismatch where Ctrl+Y does not exit prompt history mode. Do you want me to address these before merge, or merge as-is?

merge via gh cli, pull from origin, fix things up

403 | deleteWordForward | alt+d | Delete word forward | should this maybe be ctrl + d? to be in line with ctrl + backspace? what's the standard here? what standard is cltr + backspace for delete word backward? it seems like we are mixing different standards. users can still do their own keybindings, but the default ones should be consistent with "something"

Standard readline and Emacs bindings are:

Alt+Backspace (Meta+Backspace) deletes word backward
Alt+D (Meta+D) deletes word forward
Ctrl+D deletes the character under the cursor, not a word

So the current defaults follow the Emacs and readline convention. Ctrl+Backspace is not the standard, it is a common terminal or OS mapping. If you want the default to use Ctrl+D for delete word forward, that would conflict with delete char forward. If you want to change the defaults anyway, say which bindings you want and I will update them.

ok, so alt + d to delete word forward is reasonable then?

Yes, Alt+D is the standard default for delete word forward in Emacs and readline.

jesus, why did you push that feature branch. merge into main please, then push to origin

Merged and pushed to origin/main.

Tests:

npm run check failed in packages/pods and packages/tui with missing node types and other pre-existing errors.

Summary of changes merged:

Added kill ring, yank and yank-pop, delete word forward, and legacy Alt+letter matching in TUI editor.
Updated interactive mode hotkeys display.
Updated changelogs and README keybinding docs.
Yank now exits history mode for consistency.

ok, we are on main locally, please check that all the work is here