Reviewed GitHub issue and related code.
UnderstandUpdated setting types to include "none" option.
EditModified UI components for new setting.
EditRan type checks and validations.
VerifyCommitted and pushed changes with changelog.
CleanupAnalyze GitHub issue(s): https://github.com/badlogic/pi-mono/issues/973 just implement and add a changelog entry
For each issue:
Read the issue in full, including all comments and linked issues/PRs.
For bugs:
For feature requests:
Do NOT implement unless explicitly asked. Analyze and propose only.
Let me find the relevant code for the doubleEscapeAction setting:
Let me search for the escape handler where the double-escape action is implemented:
Now I understand the implementation. I need to:
"none" to the doubleEscapeAction type"none" to the UI options and type"none"Let me implement:
Now add a changelog entry:
Now run the type check:
All checks pass. Here's a summary of the changes:
Files modified:
packages/coding-agent/src/core/settings-manager.ts
"none" to the doubleEscapeAction type in Settings interfacegetDoubleEscapeAction() return type to include "none"setDoubleEscapeAction() parameter type to include "none"packages/coding-agent/src/modes/interactive/components/settings-selector.ts
SettingsConfig.doubleEscapeAction type to include "none"SettingsCallbacks.onDoubleEscapeActionChange callback type"none" to the values array for the double-escape-action settingpackages/coding-agent/src/modes/interactive/interactive-mode.ts
doubleEscapeAction === "none"packages/coding-agent/CHANGELOG.md
[Unreleased] → ### Addedlgtm, commit and push the files you changed
Done. Committed and pushed cb087586. The issue will be automatically closed via "Fixes #973" in the commit message.