Enhanced lint checks and precommit hook
Public
Enhanced lint checks and precommit hook
Agent
Pi
Model
Claude Opus 4.5 (latest)
Started
Jan 31, 11:23 PM
Messages76
Downloads0
Configured precommit hook to fail on lint warnings.
EditFixed lint issues.
EditCommitted and pushed changes, closing related issue.
Verify
run npm run check, fix the lints
The user wants me to run npm run check and fix any lint errors. Let me do that.
>cd /Users/badlogic/workspaces/pi-mono && npm run check 2>&1> pi-monorepo@0.0.3 check
> biome check --write . && tsgo --noEmit && cd packages/web-ui && npm run check
Command abortedbefore you do, can you please ensure the precommit hook fails if we get lint warnings, and not just errors
The user wants me to modify the precommit hook to fail on lint warnings, not just errors. Let me first find the precommit hook configuration.
>cd /Users/badlogic/workspaces/pi-mono && find . -name "pre-commit" -o -name ".husky" -o -name "lint-staged*" 2>/dev/null | head -20./.husky
./.husky/_/pre-commit
./.husky/pre-commit
./.git/hooks/pre-commitLet me read the husky pre-commit hook to see what it does.
The pre-commit hook runs npm run check. Let me see what the check script does in package.json.
>cd /Users/badlogic/workspaces/pi-mono && grep -A2 '"check"' package.json"check": "biome check --write . && tsgo --noEmit && cd packages/web-ui && npm run check",
"test": "npm run test --workspaces --if-present",
"version:patch": "npm version patch -ws --no-git-tag-version && node scripts/sync-versions.js && rm -rf node_modules packages/*/node_modules package-lock.json && npm install",The npm run check script runs biome check --write .. By default, biome only exits with non-zero on errors. To make it fail on warnings too, I need to add the --error-on-warnings flag.
Let me check the biome documentation or help to confirm the flag name.
>cd /Users/badlogic/workspaces/pi-mono && npx biome check --help 2>&1 | grep -i warn--error-on-warnings Tell Biome to exit with an error code if some diagnostics emit
warnings.
--log-level=<none|debug|info|warn|error> The level of logging. In order, from the most
verbose to the least verbose: debug, info, warn, error.
--diagnostic-level=<info|warn|error> The level of diagnostics to show. In order, from the
lowest to the most important: info, warn, error. PassingThe flag is --error-on-warnings. I need to add this to the check script in package.json.
Now I can edit the check script to add --error-on-warnings flag.
Now let me also check the web-ui package's check script to see if it also uses biome and needs the same flag.
>cd /Users/badlogic/workspaces/pi-mono && grep -A2 '"check"' packages/web-ui/package.json"check": "biome check --write . && tsc --noEmit && cd example && biome check --write . && tsc --noEmit"
},
"dependencies": {The web-ui package also uses biome without the --error-on-warnings flag. I need to update that as well.
I'll update the web-ui package.json to add --error-on-warnings to both biome check commands.
Now let me run npm run check to see any lint warnings/errors that need to be fixed.
Now let me run npm run check to find and fix the lint issues:
>cd /Users/badlogic/workspaces/pi-mono && npm run check 2>&1> pi-monorepo@0.0.3 check
> biome check --write --error-on-warnings . && tsgo --noEmit && cd packages/web-ui && npm run check
packages/coding-agent/src/modes/interactive/components/daxnuts.ts:49:12 lint/style/useTemplate FIXABLE ━━━━━━━━━━
i Template literals are preferred over string concatenation.
47 │ const top = pixels[row][x];
48 │ const bottom = pixels[row + 1]?.[x] ?? top;
> 49 │ line += rgb(bottom[0], bottom[1], bottom[2]) + rgb(top[0], top[1], top[2], true) + "▄";
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
50 │ }
51 │ line += RESET;
i Unsafe fix: Use a template literal.
47 47 │ const top = pixels[row][x];
48 48 │ const bottom = pixels[row + 1]?.[x] ?? top;
49 │ - → → → line·+=·rgb(bottom[0],·bottom[1],·bottom[2])·+·rgb(top[0],·top[1],·top[2],·true)·+·"▄";
49 │ + → → → line·+=·`${rgb(bottom[0],·bottom[1],·bottom[2])·+·rgb(top[0],·top[1],·top[2],·true)}▄`;
50 50 │ }
51 51 │ line += RESET;
packages/tui/test/bug-regression-isimageline-startswith-bug.test.ts:79:5 lint/style/useTemplate FIXABLE ━━━━━━━━━━
i Template literals are preferred over string concatenation.
77 │ "Middle \x1b_Ga=T,data...\x1b\\ more text",
78 │ // Very long line (simulating 300KB+ crash scenario)
> 79 │ "Text before " + "\x1b_Ga=T,f=100" + "A".repeat(300000) + " text after",
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
80 │ ];
81 │
i Unsafe fix: Use a template literal.
77 77 │ "Middle \x1b_Ga=T,data...\x1b\\ more text",
78 78 │ // Very long line (simulating 300KB+ crash scenario)
79 │ - → → → → "Text·before·"·+·"\x1b_Ga=T,f=100"·+·"A".repeat(300000)·+·"·text·after",
79 │ + → → → → `Text·before·\x1b_Ga=T,f=100${"A".repeat(300000)}·text·after`,
80 80 │ ];
81 81 │
packages/tui/test/bug-regression-isimageline-startswith-bug.test.ts:96:5 lint/style/useTemplate FIXABLE ━━━━━━━━━━
i Template literals are preferred over string concatenation.
94 │ "Middle \x1b]1337;File=inline=1:data==\x07 more text",
95 │ // Very long line (simulating 304KB crash scenario)
> 96 │ "Text before " + "\x1b]1337;File=size=800,600;inline=1:" + "B".repeat(300000) + " text after",
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
97 │ ];
98 │
i Unsafe fix: Use a template literal.
94 94 │ "Middle \x1b]1337;File=inline=1:data==\x07 more text",
95 95 │ // Very long line (simulating 304KB crash scenario)
96 │ - → → → → "Text·before·"·+·"\x1b]1337;File=size=800,600;inline=1:"·+·"B".repeat(300000)·+·"·text·after",
96 │ + → → → → `Text·before·\x1b]1337;File=size=800,600;inline=1:${"B".repeat(300000)}·text·after`,
97 97 │ ];
98 98 │
Skipped 3 suggested fixes.
If you wish to apply the suggested (unsafe) fixes, use the command biome check --write --unsafe
Checked 451 files in 300ms. No fixes applied.
Found 3 infos.
> @mariozechner/pi-web-ui@0.50.7 check
> biome check --write --error-on-warnings . && tsc --noEmit && cd example && biome check --write --error-on-warnings . && tsc --noEmit
Checked 73 files in 36ms. No fixes applied.
Checked 3 files in 7ms. No fixes applied.There are 3 template literal warnings. I need to fix them manually since they're marked as "unsafe" fixes. Let me read and fix these files.
Found 3 template literal warnings. Let me fix them:
Now let me fix these three issues. I'll use template literals instead of string concatenation.
Now let me run npm run check again to verify all issues are fixed.
>cd /Users/badlogic/workspaces/pi-mono && npm run check 2>&1> pi-monorepo@0.0.3 check
> biome check --write --error-on-warnings . && tsgo --noEmit && cd packages/web-ui && npm run check
Checked 451 files in 295ms. No fixes applied.
> @mariozechner/pi-web-ui@0.50.7 check
> biome check --write --error-on-warnings . && tsc --noEmit && cd example && biome check --write --error-on-warnings . && tsc --noEmit
Checked 73 files in 36ms. No fixes applied.
Checked 3 files in 7ms. No fixes applied.All checks pass now. Let me summarize what was done.
Done. Changes made:
Updated pre-commit hook to fail on warnings by adding --error-on-warnings to biome:
package.json: check scriptpackages/web-ui/package.json: check script (both biome calls)Fixed 3 template literal warnings:
packages/coding-agent/src/modes/interactive/components/daxnuts.ts:49 - string concatenation → template literalpackages/tui/test/bug-regression-isimageline-startswith-bug.test.ts:79 - string concatenation → template literalpackages/tui/test/bug-regression-isimageline-startswith-bug.test.ts:96 - string concatenation → template literalcommit and push, then close this issue with a comment "Thanks, fixed on main"https://github.com/badlogic/pi-mono/issues/1103
The user wants me to commit and push the changes, then close issue #1103 with a comment. Let me first check the issue to understand what it's about, then commit the specific files I modified.
>cd /Users/badlogic/workspaces/pi-mono && git statusOn branch main
Your branch is behind 'origin/main' by 1 commit, and can be fast-forwarded.
(use "git pull" to update your local branch)
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: package.json
modified: packages/coding-agent/src/modes/interactive/components/daxnuts.ts
modified: packages/tui/test/bug-regression-isimageline-startswith-bug.test.ts
modified: packages/web-ui/package.json
no changes added to commit (use "git add" and/or "git commit -a")I need to pull first to update, then add my specific files, commit, and push. Let me do that.
>cd /Users/badlogic/workspaces/pi-mono && git pull --rebaseerror: cannot pull with rebase: You have unstaged changes.
error: Please commit or stash them.
Command exited with code 128I need to stage my changes first. Let me add my specific files, then commit, then pull with rebase, then push.
>cd /Users/badlogic/workspaces/pi-mono && git add package.json packages/coding-agent/src/modes/interactive/components/daxnuts.ts packages/tui/test/bug-regression-isimageline-startswith-bug.test.ts packages/web-ui/package.json && git commit -m "fix: make pre-commit hook fail on lint warnings, fix template literal warnings
- Add --error-on-warnings to biome check in root and web-ui package.json
- Convert string concatenation to template literals in daxnuts.ts
- Convert string concatenation to template literals in test file
Fixes #1103"Running formatting, linting, and type checking...
> pi-monorepo@0.0.3 check
> biome check --write --error-on-warnings . && tsgo --noEmit && cd packages/web-ui && npm run check
Checked 451 files in 293ms. No fixes applied.
> @mariozechner/pi-web-ui@0.50.7 check
> biome check --write --error-on-warnings . && tsc --noEmit && cd example && biome check --write --error-on-warnings . && tsc --noEmit
Checked 73 files in 36ms. No fixes applied.
Checked 3 files in 8ms. No fixes applied.
✅ All pre-commit checks passed!
[main cc6b804a] fix: make pre-commit hook fail on lint warnings, fix template literal warnings
4 files changed, 5 insertions(+), 5 deletions(-)Great, the commit was successful. Now let me pull with rebase and push.
>cd /Users/badlogic/workspaces/pi-mono && git pull --rebase && git pushRebasing (1/1)
Successfully rebased and updated refs/heads/main.
To https://github.com/badlogic/pi-mono.git
7eae0a7d..1bd68327 main -> mainNow let me close the issue with a comment.
>cd /Users/badlogic/workspaces/pi-mono && gh issue close 1103 --comment "Thanks, fixed on main"! Issue badlogic/pi-mono#1103 (biome: fix useTemplate lint infos in coding-agent + tui) is already closedThe issue was already closed (probably by the "Fixes #1103" in the commit message). Let me add the comment anyway.
Issue was already auto-closed by the commit. Let me add the comment:
>cd /Users/badlogic/workspaces/pi-mono && gh issue comment 1103 --body "Thanks, fixed on main"https://github.com/badlogic/pi-mono/issues/1103#issuecomment-3829584995Done! I've completed all the tasks:
--error-on-warnings to biomeDone. Committed and pushed to main. Issue #1103 was auto-closed by the Fixes #1103 in the commit message, and I added the comment.