Fixed error handling in write toolPublic

Agent

Model

Claude Opus 4.5 (latest)

Started

Jan 19, 9:26 PM

Messages83

Downloads0

Summary

Closed, Completed

Understand
Analyzed GitHub issue and related code.
Understand
Understand
Identified root cause in write tool error handling.
Understand
Edit
Fixed error handling in write tool.
Edit
Verify
Provided test command for validation.
Verify
Cleanup
Removed test extension and committed fix.
Cleanup

Analyze GitHub issue(s): https://github.com/badlogic/pi-mono/issues/856

For each issue:

Read the issue in full, including all comments and linked issues/PRs.
For bugs:
- Ignore any root cause analysis in the issue (likely wrong)
- Read all related code files in full (no truncation)
- Trace the code path and identify the actual root cause
- Propose a fix
For feature requests:
- Read all related code files in full (no truncation)
- Propose the most concise implementation approach
- List affected files and changes needed

Do NOT implement unless explicitly asked. Analyze and propose only.

Let me analyze this bug. I need to look at the ToolExecutionComponent and how it handles errors for different tools.

Found the bug. Let me examine the write tool case in detail and compare with how edit handles errors:

Root Cause Analysis:

In tool-execution.ts, the formatToolExecution() method handles different built-in tools. Looking at the write case (lines 430-453):

typescript

} else if (this.toolName === "write") {    const rawPath = this.args?.file_path || this.args?.path || "";    const path = shortenPath(rawPath);    const fileContent = this.args?.content || "";    // ... renders fileContent from args ...        // NO ERROR HANDLING - missing check for this.result?.isError}

Compare this to the edit case (lines 455-482) which properly handles errors:

typescript

} else if (this.toolName === "edit") {    // ...    if (this.result?.isError) {        // Show error from result        const errorText = this.getTextOutput();        if (errorText) {            text += `\n\n${theme.fg("error", errorText)}`;        }    } else if (this.result?.details?.diff) {        // ...    }}

The write tool case:

Only renders the content from args (what's being written)
Never checks this.result?.isError
Never calls this.getTextOutput() to display error messages

Other tools (bash, read, ls, find, grep) all display output from this.getTextOutput() which includes error text. Only write is missing this.

Proposed Fix:

Add error handling to the write case in formatToolExecution():

typescript

} else if (this.toolName === "write") {    const rawPath = this.args?.file_path || this.args?.path || "";    const path = shortenPath(rawPath);    const fileContent = this.args?.content || "";    // ... existing code to render header and content ...
    // ADD: Show error if tool execution failed    if (this.result?.isError) {        const errorText = this.getTextOutput();        if (errorText) {            text += `\n\n${theme.fg("error", errorText)}`;        }    }}

Affected File:

packages/coding-agent/src/modes/interactive/components/tool-execution.ts (lines ~430-453)

fix it

Now let me update the changelog:

Fixed. Summary:

Change: Added error handling to the write tool case in ToolExecutionComponent.formatToolExecution()

File: packages/coding-agent/src/modes/interactive/components/tool-execution.ts

The write tool was only rendering the content from args, never checking this.result?.isError or displaying error text. Added the same error handling pattern used by the edit tool:

write a minimal extension so i can test this. the user linked to a simple write tool extension implementation

Created test extension at test-write-error-extension/.

To test:

Then prompt: write "hello" to /tmp/test.txt

The write tool should now display the error "Simulated write error: cannot write to /tmp/test.txt" in the UI with a red error background.

You can also test without the extension by writing to a restricted path:

➜ pi-mono git:(main) ✗ ./pi-test.sh -e test-write-error-extension/index.js Failed to load extension "/Users/badlogic/workspaces/pi-mono/test-write-error-extension/index.js": Failed to load extension: pi.addTool is not a function

are you fucking stupid? read @packages/coding-agent/docs/extensions.md in full, no truncation

Fixed. Test with:

Then prompt: write "hello" to /tmp/test.txt

ok remove the test extension, commit and push

Done. Committed and pushed: fix(coding-agent): show errors from write tool in UI (closes #856)

} else if (this.toolName === "write") { const rawPath = this.args?.file_path || this.args?.path || ""; const path = shortenPath(rawPath); const fileContent = this.args?.content || ""; // ... renders fileContent from args ... // NO ERROR HANDLING - missing check for this.result?.isError}

} else if (this.toolName === "edit") { // ... if (this.result?.isError) { // Show error from result const errorText = this.getTextOutput(); if (errorText) { text += `\n\n${theme.fg("error", errorText)}`; } } else if (this.result?.details?.diff) { // ... }}

} else if (this.toolName === "write") { const rawPath = this.args?.file_path || this.args?.path || ""; const path = shortenPath(rawPath); const fileContent = this.args?.content || ""; // ... existing code to render header and content ... // ADD: Show error if tool execution failed if (this.result?.isError) { const errorText = this.getTextOutput(); if (errorText) { text += `\n\n${theme.fg("error", errorText)}`; } }}