Pulled and merged GitHub PR #816Public

Let me read the linked issue #813 and the existing source files:

Let me check the existing documentation and verify the CHANGELOG format:

Now let me pull this PR into a local branch for testing:

Successfully checked out the PR branch. Here's my review:

PR: https://github.com/badlogic/pi-mono/pull/816

Changelog:

• Entry exists under ### Added in packages/coding-agent/CHANGELOG.md
• Missing attribution: External contribution from @w-winter should include PR link and author per AGENTS.md format:
  • - Added feature ([#816](https://github.com/badlogic/pi-mono/pull/816) by [@w-winter](https://github.com/w-winter))

Good:

• Comprehensive fix for race conditions in scope toggling with allLoadSeq sequencing to ignore stale results
• Prevents redundant concurrent "All sessions" loads with allLoading flag
• Proper error handling with .catch() for loader failures (previously could leave UI stuck)
• Uses trash CLI when available for safer deletion with fallback to unlink
• Blocks deletion of currently active session (good safeguard)
• Status messages auto-hide with timeout and trigger re-render
• Thorough test coverage for delete confirmation, scope race protection, and redundant load suppression
• Documentation updated in README.md and docs/session.md
• Clean separation of concerns: header manages display state, list handles input

Bad:

• PR has merge conflicts (mergeable: "CONFLICTING") that need resolution before merge
• spawnSync is used synchronously in an async function. While acceptable for a quick trash call, it briefly blocks the event loop
• Changelog entries missing PR link and author attribution for external contribution

Ugly:

• None identified

Questions or Assumptions:

• The undocumented Ctrl+Backspace convenience binding only triggers delete when search query is empty. Is this behavior desirable to keep? The PR author asks for feedback on this.
• Should Ctrl+Backspace be documented if kept?

Change summary:

• Ctrl+P: Toggle display of session .jsonl file paths in /resume picker
• Ctrl+D: Delete selected session with inline confirmation (uses trash when available)
• Ctrl+Backspace: Same as Ctrl+D but only when search query is empty
• Fixed race conditions when rapidly toggling scope while "All sessions" loads
• Added error handling for session loader failures
• Split hint line into two lines for better readability at narrow widths
• Active session cannot be deleted (error shown)

Tests:

• New test file: packages/coding-agent/test/session-selector-path-delete.test.ts
• Tests delete confirmation behavior (Ctrl+D)
• Tests Ctrl+Backspace not triggering delete when search query is non-empty
• Tests scope load race protection (All resolves after switching back to Current)
• Tests redundant All-load suppression while inflight

The branch pr-816-resume-additions is now checked out locally for testing. Note the PR has merge conflicts that will need resolution. You can test with:

npm run check  # verify it compilesnpm test -- packages/coding-agent/test/session-selector-path-delete.test.ts  # run the new tests

Done. The layout is now:

───────────────────────────────────────────────────────────────────────────────────────────────────────────
Resume Session (Current Folder)                                       ◉ Current Folder | ○ All  Sort: FuzzyTab: scope · re:<pattern> for regex · "phrase" for exact phraseCtrl+R: sort · Ctrl+D: delete · Ctrl+P: path (off)
>

Checks pass. You can test it with /resume in interactive mode.

The session selector uses hardcoded strings like "Tab: scope" but other selectors use the keyHint()/rawKeyHint() system with format "key description" (no colon). Let me fix this:

Done. Now the hints use the consistent keyHint()/rawKeyHint() system:

tab scope · re:<pattern> regex · "phrase" exactctrl+r sort · ctrl+d delete · ctrl+p path (off)

Keys are styled with dim color, descriptions with muted (matching extension-selector and tree-selector patterns). Checks pass.

Simple conflict in CHANGELOG.md - just needs both entries combined. I'll resolve it and also add the required PR attribution for the external contribution:

Conflict resolved. Here's the summary:

Conflict: Just the CHANGELOG.md, where both main and the PR added entries under ### Added. Resolved by keeping both entries, with proper attribution added for the external contribution.

Current state:

• Branch pr-816-resume-additions is rebased on origin/main
• My adjustments (border moved above header, keybinding hints) are applied
• All checks pass
• All 5 tests pass

Changes made by us:

1. Moved DynamicBorder above the header
2. Updated hint lines to use keyHint()/rawKeyHint() for consistent styling
3. Resolved CHANGELOG conflict and added proper PR attribution: ([#816](https://github.com/badlogic/pi-mono/pull/816) by [@w-winter](https://github.com/w-winter))

Ready for you to test interactively with /resume.

Done.

• Committed style adjustments
• Merged to main (fast-forward)
• Pushed to origin
• Closed PR #816 with comment thanking the contributor
• Cleaned up local branch