Fixed extension loading despite no-extensions flagPublic

Agent

Model

Claude Opus 4.5 (latest)

Started

Jan 16, 8:55 PM

Messages44

Downloads0

Summary

Closed, Completed

Understand
Reviewed GitHub issue and related code.
Understand
Build
Implemented fix to respect no-extensions flag.
Build
Edit
Updated changelog and left issue comment.
Edit
Verify
Committed and pushed fix, confirmed closure.
Verify

Analyze GitHub issue(s): https://github.com/badlogic/pi-mono/issues/776

For each issue:

Read the issue in full, including all comments and linked issues/PRs.
For bugs:
- Ignore any root cause analysis in the issue (likely wrong)
- Read all related code files in full (no truncation)
- Trace the code path and identify the actual root cause
- Propose a fix
For feature requests:
- Read all related code files in full (no truncation)
- Propose the most concise implementation approach
- List affected files and changes needed

Do NOT implement unless explicitly asked. Analyze and propose only.

Let me read the relevant code files to verify the root cause analysis.

Analysis of Issue #776

Summary

The --no-extensions flag doesn't prevent extension discovery. Extensions from ~/.pi/agent/extensions/ and .pi/extensions/ are still loaded despite the flag.

Root Cause Analysis (Verified)

The issue's root cause analysis is correct.

Code path:

main.ts lines 291-293 - In buildSessionOptions():

When --no-extensions is used, extensionsResult.extensions is an empty array [], so:
- extensionsResult.extensions.length > 0 → false
- preloadedExtensions is not set on the options object
sdk.ts lines 274-289 - In createAgentSession():

typescript

if (options.preloadedExtensions !== undefined) {    extensionsResult = options.preloadedExtensions;} else if (options.extensions !== undefined) {    // ...skip discovery...} else {    // Discover extensions <-- FALLS THROUGH HERE    extensionsResult = await discoverAndLoadExtensions(...);}

Since preloadedExtensions is undefined, the SDK falls through to the else branch and rediscovers extensions.

Proposed Fix

File: packages/coding-agent/src/main.ts

Change: Remove the .length > 0 condition:

typescript

// Before (line 291-293):if (extensionsResult && extensionsResult.extensions.length > 0) {    options.preloadedExtensions = extensionsResult;}
// After:if (extensionsResult) {    options.preloadedExtensions = extensionsResult;}

This ensures the empty extensionsResult is passed through, signaling to createAgentSession() that extension loading was already handled (and resulted in zero extensions).

implement, comit and push, leave a comment on the issue in my tone, don't forget changelog

Done. The fix was committed (3326b8f5) and pushed to main. The issue was auto-closed by the commit message.

Summary:

Removed the .length > 0 condition in main.ts line 291-293
Added changelog entry under ### Fixed
Left a comment confirming the fix

Analysis of Issue #776

Summary

The --no-extensions flag doesn't prevent extension discovery. Extensions from ~/.pi/agent/extensions/ and .pi/extensions/ are still loaded despite the flag.

Root Cause Analysis (Verified)

The issue's root cause analysis is correct.

Code path:

main.ts lines 291-293 - In buildSessionOptions():

When --no-extensions is used, extensionsResult.extensions is an empty array [], so:

extensionsResult.extensions.length > 0 → false
preloadedExtensions is not set on the options object

sdk.ts lines 274-289 - In createAgentSession():

typescript

if (options.preloadedExtensions !== undefined) {    extensionsResult = options.preloadedExtensions;} else if (options.extensions !== undefined) {    // ...skip discovery...} else {    // Discover extensions <-- FALLS THROUGH HERE    extensionsResult = await discoverAndLoadExtensions(...);}

if (options.preloadedExtensions !== undefined) {    extensionsResult = options.preloadedExtensions;} else if (options.extensions !== undefined) {    // ...skip discovery...} else {    // Discover extensions <-- FALLS THROUGH HERE    extensionsResult = await discoverAndLoadExtensions(...);}

Since preloadedExtensions is undefined, the SDK falls through to the else branch and rediscovers extensions.

Proposed Fix

File: packages/coding-agent/src/main.ts

Change: Remove the .length > 0 condition:

This ensures the empty extensionsResult is passed through, signaling to createAgentSession() that extension loading was already handled (and resulted in zero extensions).