Srihari Sriraman shared in

Public

Fixed extension loading despite no-extensions flagPublic

Agent

Model

Claude Opus 4.5 (latest)

Started

Jan 16, 8:55 PM

Messages44

Downloads0

Summary

Closed, Completed

Understand
Reviewed GitHub issue and related code.
Understand
Build
Implemented fix to respect no-extensions flag.
Build
Edit
Updated changelog and left issue comment.
Edit
Verify
Committed and pushed fix, confirmed closure.
Verify

Analyze GitHub issue(s): https://github.com/badlogic/pi-mono/issues/776

For each issue:

Read the issue in full, including all comments and linked issues/PRs.
For bugs:
- Ignore any root cause analysis in the issue (likely wrong)
- Read all related code files in full (no truncation)
- Trace the code path and identify the actual root cause
- Propose a fix
For feature requests:
- Read all related code files in full (no truncation)
- Propose the most concise implementation approach
- List affected files and changes needed

Do NOT implement unless explicitly asked. Analyze and propose only.

>gh issue view 776 --json title,body,comments,labels,state --repo badlogic/pi-mono

{"body":"**DISCLAIMER:** The issue was investigated and described by Pi with Opus 4.5.\n\n## Bug\n\nThe `--no-extensions` CLI flag does not prevent extensions from being loaded. Extensions from `~/.pi/agent/extensions/` and `.pi/extensions/` are still discovered and loaded. This happens in both versions 0.46.0 and 0.47.0.\n\n## Reproduction\n\n1. Create an extension in `~/.pi/agent/extensions/test.ts`:\n```typescript\nimport type { ExtensionAPI } from \"@mariozechner/pi-coding-agent\";\nconsole.error(\">>> EXTENSION LOADED <<<\");\nexport default function (pi: ExtensionAPI) {}\n```\n\n2. Run `pi --no-extensions -p \"test\"`\n3. Observe that `>>> EXTENSION LOADED <<<` is printed (it should not be)\n\n## Root cause\n\nIn `main.js`, `buildSessionOptions()` only sets `preloadedExtensions` when extensions were actually loaded:\n\n```javascript\n// Pre-loaded extensions (from early CLI flag discovery)\nif (extensionsResult && extensionsResult.extensions.length > 0) {\n    options.preloadedExtensions = extensionsResult;\n}\n```\n\nWhen `--no-extensions` is used, `extensionsResult.extensions` is an empty array, so `preloadedExtensions` is not set. Then in `createAgentSession()` (sdk.js), since `preloadedExtensions` is undefined, it falls through to the discovery branch and loads extensions anyway.\n\n## Fix\n\nRemove the `.length > 0` condition so the empty result is passed through, signaling that extension loading was already handled:\n\n```javascript\nif (extensionsResult) {\n    options.preloadedExtensions = extensionsResult;\n}\n```\n","comments":[],"labels":[],"state":"OPEN","title":"The --no-extensions flag doesn't prevent extension discovery"}

Let me analyze this bug. The issue describes that --no-extensions doesn't work properly. The proposed root cause is in main.js where buildSessionOptions() only sets preloadedExtensions when extensions were actually loaded (checking .length > 0).

Let me read the relevant code files to verify the actual root cause:

The main entry point (main.ts/main.js)
The SDK session creation (sdk.ts/sdk.js)
Extension loading code

Let me find and read these files.

Let me read the relevant code files to verify the root cause analysis.

>find /Users/badlogic/workspaces/pi-mono/packages/coding-agent/src -name "*.ts" | xargs grep -l "no-extensions\|preloadedExtensions\|buildSessionOptions" 2>/dev/null

/Users/badlogic/workspaces/pi-mono/packages/coding-agent/src/core/sdk.ts
/Users/badlogic/workspaces/pi-mono/packages/coding-agent/src/main.ts
/Users/badlogic/workspaces/pi-mono/packages/coding-agent/src/cli/args.ts

Now I have read all the relevant code. Let me trace the issue:

In main.ts, buildSessionOptions() at lines 206-208:

The condition extensionsResult.extensions.length > 0 means when --no-extensions is passed, the empty array result is not passed through.

In sdk.ts, at the createAgentSession() function, around lines 274-289:

typescript

// Load extensions (discovers from standard locations + configured paths)let extensionsResult: LoadExtensionsResult;if (options.preloadedExtensions !== undefined) {    // Use pre-loaded extensions (from early CLI flag discovery)    extensionsResult = options.preloadedExtensions;} else if (options.extensions !== undefined) {    // User explicitly provided extensions array (even if empty) - skip discovery    // Create runtime for inline extensions    const runtime = createExtensionRuntime();    extensionsResult = {        extensions: [],        errors: [],        runtime,    };} else {    // Discover extensions, merging with additional paths    const configuredPaths = [...settingsManager.getExtensionPaths(), ...(options.additionalExtensionPaths ?? [])];    extensionsResult = await discoverAndLoadExtensions(configuredPaths, cwd, agentDir, eventBus);    time("discoverAndLoadExtensions");    for (const { path, error } of extensionsResult.errors) {        console.error(`Failed to load extension "${path}": ${error}`);    }}

If options.preloadedExtensions is undefined, it falls through to the discovery branch and calls discoverAndLoadExtensions().

The root cause is clear: when --no-extensions is used, the empty result gets filtered out in main.ts, so preloadedExtensions stays undefined. This causes createAgentSession() to skip the preloaded check and instead trigger the discovery logic, which loads extensions anyway. The fix is straightforward—remove the length check so the empty array gets passed through as intended.

Looking at the actual code location, the problematic condition is:

This needs to become:

Since extensionsResult is always assigned earlier in the flow, we could technically remove the condition entirely, but keeping the safety check aligns with the proposed solution and maintains defensive coding practices.

Analysis of Issue #776

Summary

The --no-extensions flag doesn't prevent extension discovery. Extensions from ~/.pi/agent/extensions/ and .pi/extensions/ are still loaded despite the flag.

Root Cause Analysis (Verified)

The issue's root cause analysis is correct.

Code path:

main.ts lines 291-293 - In buildSessionOptions():

When --no-extensions is used, extensionsResult.extensions is an empty array [], so:
- extensionsResult.extensions.length > 0 → false
- preloadedExtensions is not set on the options object
sdk.ts lines 274-289 - In createAgentSession():

typescript

if (options.preloadedExtensions !== undefined) {    extensionsResult = options.preloadedExtensions;} else if (options.extensions !== undefined) {    // ...skip discovery...} else {    // Discover extensions <-- FALLS THROUGH HERE    extensionsResult = await discoverAndLoadExtensions(...);}

Since preloadedExtensions is undefined, the SDK falls through to the else branch and rediscovers extensions.

Proposed Fix

File: packages/coding-agent/src/main.ts

Change: Remove the .length > 0 condition:

typescript

// Before (line 291-293):if (extensionsResult && extensionsResult.extensions.length > 0) {    options.preloadedExtensions = extensionsResult;}
// After:if (extensionsResult) {    options.preloadedExtensions = extensionsResult;}

This ensures the empty extensionsResult is passed through, signaling to createAgentSession() that extension loading was already handled (and resulted in zero extensions).

implement, comit and push, leave a comment on the issue in my tone, don't forget changelog

Editedmain.ts

EditedCHANGELOG.md

>cd /Users/badlogic/workspaces/pi-mono && npm run check 2>&1

> pi-monorepo@0.0.3 check
> biome check --write . && tsgo --noEmit && npm run check -w @mariozechner/pi-web-ui

Checked 406 files in 451ms. No fixes applied.

> @mariozechner/pi-web-ui@0.47.0 check
> biome check --write . && tsc --noEmit && cd example && biome check --write . && tsc --noEmit

Checked 73 files in 47ms. No fixes applied.
Checked 3 files in 8ms. No fixes applied.

>cd /Users/badlogic/workspaces/pi-mono && git add -A && git commit -m "Fix --no-extensions flag not preventing extension discovery

When --no-extensions was used, extensionsResult.extensions was an empty
array. The condition in buildSessionOptions() checked .length > 0,
so preloadedExtensions was not set. This caused createAgentSession()
to fall through to extension discovery.

Remove the .length > 0 condition so the empty result is passed through,
signaling that extension loading was already handled.

Fixes #776"

Running formatting, linting, and type checking...

> pi-monorepo@0.0.3 check
> biome check --write . && tsgo --noEmit && npm run check -w @mariozechner/pi-web-ui

Checked 406 files in 309ms. No fixes applied.

> @mariozechner/pi-web-ui@0.47.0 check
> biome check --write . && tsc --noEmit && cd example && biome check --write . && tsc --noEmit

Checked 73 files in 47ms. No fixes applied.
Checked 3 files in 8ms. No fixes applied.
✅ All pre-commit checks passed!
[main 3326b8f5] Fix --no-extensions flag not preventing extension discovery
 2 files changed, 2 insertions(+), 1 deletion(-)

>gh issue comment 776 --repo badlogic/pi-mono --body "Fixed in 3326b8f5. Your analysis was spot on. Removed the \`.length > 0\` condition so the empty result gets passed through."

https://github.com/badlogic/pi-mono/issues/776#issuecomment-3761799143

Done. The fix was committed (3326b8f5) and pushed to main. The issue was auto-closed by the commit message.

Summary:

Removed the .length > 0 condition in main.ts line 291-293
Added changelog entry under ### Fixed
Left a comment confirming the fix